From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 27 Jun 2014 04:58:56 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:55787 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6856571AbaF0C6jkrGk0 (ORCPT ); Fri, 27 Jun 2014 04:58:39 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id CBC08EA143A3A; Fri, 27 Jun 2014 03:58:31 +0100 (IST) Received: from hhmail02.hh.imgtec.org (10.100.10.20) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 27 Jun 2014 03:58:32 +0100 Received: from BAMAIL02.ba.imgtec.org (192.168.66.28) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 27 Jun 2014 03:58:32 +0100 Received: from [10.20.2.221] (10.20.2.221) by bamail02.ba.imgtec.org (192.168.66.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 26 Jun 2014 15:44:49 -0700 Message-ID: <53ACA261.7040007@imgtec.com> Date: Thu, 26 Jun 2014 15:44:49 -0700 From: Deng-Cheng Zhu User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: David Daney CC: , , , , , , Subject: Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_" References: <1403809900-17454-1-git-send-email-dengcheng.zhu@imgtec.com> <1403809900-17454-6-git-send-email-dengcheng.zhu@imgtec.com> <53AC7466.6070401@gmail.com> <53AC7AAD.7010007@imgtec.com> <53AC96D7.8040208@gmail.com> In-Reply-To: <53AC96D7.8040208@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.20.2.221] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 40865 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: dengcheng.zhu@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 06/26/2014 02:55 PM, David Daney wrote: > On 06/26/2014 12:55 PM, Deng-Cheng Zhu wrote: >> On 06/26/2014 12:28 PM, David Daney wrote: >>> On 06/26/2014 12:11 PM, Deng-Cheng Zhu wrote: >>>> From: Deng-Cheng Zhu >>>> >>>> Since all the files are in arch/mips/kvm/, there's no need of the >>>> prefixes >>>> "kvm_" and "kvm_mips_". >>>> >>> >>> I don't like this change. >>> >>> It will leads me to confuse arch/mips/kvm/interrupt.h with >>> include/linux/interrupt.h >> >> We have and "interrupt.h". >> >>> >>> x86 calls these things irq.c and irq.h, perhaps that would be a little >>> better. >> >> There's also include/linux/irq.h >> > > Yes, I know. I simply wanted to let you know that if arch/mips/kvm/interrupt.h and include/linux/interrupt.h are consufing, then arch/x86/kvm/irq.h and include/linux/irq.h the same -- not even a little better. > >>> >>> There is precedence in x86 for some of the names though. >>> >>> But really why churn up the code in the first place? the kvm_mips >>> prefix does tell us exactly what we are dealing with. >> >> That's why people created the arch/mips/kvm directory, isn't it? > > No. Segregating things into directories keeps code related to one > functional area together. > > File names are different. They should carry as much meaning as possible. Remember that directory path is also part of file info. > > For examples of this look at some of these directories: > > drivers/net/ethernet/intel/ixgb > drivers/i2c/busses One can find way more examples not having prefixes. Look at kernel/events/. In the beginning, Perf-events has things under kernel. Then people did things like: kernel/perf_event.c -> kernel/events/core.c If it's kernel/events/perf_events_core.c, I think it looks ugly. Other examples are kernel/sched/, mm/, and many more. When talking about filemap.c, one may think it may be under fs/. But there's mm/filemap.c (not mm/mm_filemap.c which seems, again, ugly). What I want to say is that: Talking about a file should include its path. Deng-Cheng From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:55787 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6856571AbaF0C6jkrGk0 (ORCPT ); Fri, 27 Jun 2014 04:58:39 +0200 Message-ID: <53ACA261.7040007@imgtec.com> Date: Thu, 26 Jun 2014 15:44:49 -0700 From: Deng-Cheng Zhu MIME-Version: 1.0 Subject: Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_" References: <1403809900-17454-1-git-send-email-dengcheng.zhu@imgtec.com> <1403809900-17454-6-git-send-email-dengcheng.zhu@imgtec.com> <53AC7466.6070401@gmail.com> <53AC7AAD.7010007@imgtec.com> <53AC96D7.8040208@gmail.com> In-Reply-To: <53AC96D7.8040208@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: David Daney Cc: pbonzini@redhat.com, gleb@kernel.org, kvm@vger.kernel.org, sanjayl@kymasys.com, james.hogan@imgtec.com, ralf@linux-mips.org, linux-mips@linux-mips.org Message-ID: <20140626224449.CCIA28qI6_R7Aap4cYfSEGERna_w0uBDihwd0dXjRLE@z> On 06/26/2014 02:55 PM, David Daney wrote: > On 06/26/2014 12:55 PM, Deng-Cheng Zhu wrote: >> On 06/26/2014 12:28 PM, David Daney wrote: >>> On 06/26/2014 12:11 PM, Deng-Cheng Zhu wrote: >>>> From: Deng-Cheng Zhu >>>> >>>> Since all the files are in arch/mips/kvm/, there's no need of the >>>> prefixes >>>> "kvm_" and "kvm_mips_". >>>> >>> >>> I don't like this change. >>> >>> It will leads me to confuse arch/mips/kvm/interrupt.h with >>> include/linux/interrupt.h >> >> We have and "interrupt.h". >> >>> >>> x86 calls these things irq.c and irq.h, perhaps that would be a little >>> better. >> >> There's also include/linux/irq.h >> > > Yes, I know. I simply wanted to let you know that if arch/mips/kvm/interrupt.h and include/linux/interrupt.h are consufing, then arch/x86/kvm/irq.h and include/linux/irq.h the same -- not even a little better. > >>> >>> There is precedence in x86 for some of the names though. >>> >>> But really why churn up the code in the first place? the kvm_mips >>> prefix does tell us exactly what we are dealing with. >> >> That's why people created the arch/mips/kvm directory, isn't it? > > No. Segregating things into directories keeps code related to one > functional area together. > > File names are different. They should carry as much meaning as possible. Remember that directory path is also part of file info. > > For examples of this look at some of these directories: > > drivers/net/ethernet/intel/ixgb > drivers/i2c/busses One can find way more examples not having prefixes. Look at kernel/events/. In the beginning, Perf-events has things under kernel. Then people did things like: kernel/perf_event.c -> kernel/events/core.c If it's kernel/events/perf_events_core.c, I think it looks ugly. Other examples are kernel/sched/, mm/, and many more. When talking about filemap.c, one may think it may be under fs/. But there's mm/filemap.c (not mm/mm_filemap.c which seems, again, ugly). What I want to say is that: Talking about a file should include its path. Deng-Cheng