From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Michel_D=E4nzer?= <michel@daenzer.net>
Subject: Re: [PATCH 1/2] drm/radeon: Only enable and handle pageflip interrupts
 when needed
Date: Fri, 27 Jun 2014 10:03:21 +0900
Message-ID: <53ACC2D9.2000301@daenzer.net>
References: <1403774992-3323-1-git-send-email-michel@daenzer.net>
 <53ABF846.4080401@vodafone.de>
 <9aa408219bd9419fdced7f7501a8dfa0@mail.ud03.udmedia.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51])
 by gabe.freedesktop.org (Postfix) with ESMTP id 98EF56E392
 for <dri-devel@lists.freedesktop.org>; Thu, 26 Jun 2014 18:03:28 -0700 (PDT)
In-Reply-To: <9aa408219bd9419fdced7f7501a8dfa0@mail.ud03.udmedia.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: =?ISO-8859-1?Q?Dieter_N=FCtzel?= <Dieter@nuetzel-hh.de>, =?ISO-8859-1?Q?Christian_K=F6nig?= <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 27.06.2014 09:53, Dieter N=FCtzel wrote:
> Am 26.06.2014 12:39, schrieb Christian K=F6nig:
>> Am 26.06.2014 11:29, schrieb Michel D=E4nzer:
>>> From: Michel D=E4nzer <michel.daenzer@amd.com>
>>>
>>> Prevents radeon_crtc_handle_flip() from running before
>>> radeon_flip_work_func(), resulting in a kernel panic due to the BUG_ON()
>>> in drm_vblank_put().
>>>
>>> Tested-by: Dieter N=FCtzel <Dieter@nuetzel-hh.de>
>>> Signed-off-by: Michel D=E4nzer <michel.daenzer@amd.com>
>>
>> Does patch #2 alone fixes the problem as well?
> =

> With #2 alone I get this during boot up (before plymouth):

[...]

> [   15.259867] [drm:radeon_crtc_handle_flip] *ERROR*
> radeon_crtc->flip_status =3D 0 !=3D RADEON_FLIP_SUBMITTED(2)

That's the original patch I sent to you along with two others for
testing. The patch I submitted in this series has these messages
downgraded to debugging messages, as they just show the patch preventing
bad stuff from happening as designed.

The question is, can you reproduce the panic or the 'impossible msc'
lines in the Xorg log with only patch #2?


> But with Michel's #1+2 and 3 I got this in Xorg.0.log:
> (See Xorg.0.log.old.xz)
> =

> (EE) [mi] EQ overflowing.  Additional events will be discarded until
> existing events are processed.

That may not be directly related to the page flipping issues.


-- =

Earthling Michel D=E4nzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer