From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0RFV-0006cE-M2 for qemu-devel@nongnu.org; Fri, 27 Jun 2014 04:11:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0RFP-0002Cq-SR for qemu-devel@nongnu.org; Fri, 27 Jun 2014 04:11:09 -0400 Received: from mail-bl2lp0203.outbound.protection.outlook.com ([207.46.163.203]:40139 helo=na01-bl2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0RFP-0002Cd-Ot for qemu-devel@nongnu.org; Fri, 27 Jun 2014 04:11:03 -0400 Message-ID: <53AD1F5F.3040504@freescale.com> Date: Fri, 27 Jun 2014 10:38:07 +0300 From: Diana Craciun MIME-Version: 1.0 References: <1403802973-20841-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1403802973-20841-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-arm: Implement vCPU reset via KVM_ARM_VCPU_INIT for 32-bit CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: patches@linaro.org, qemu-devel@nongnu.org, kvmarm@lists.cs.columbia.edu On 06/26/2014 08:16 PM, Peter Maydell wrote: > Implement kvm_arm_vcpu_init() as a simple call to arm_arm_vcpu_init() > (which uses the KVM_ARM_VCPU_INIT vcpu ioctl to tell the kernel > to re-initialize the vCPU), rather than via the complicated code > which saves a copy of the register state on first init and then > writes it back to the kernel. This is much simpler and brings the > 32-bit KVM code into line with the 64-bit code. > > > Signed-off-by: Peter Maydell > --- > The kernel has always supported being able to call VCPU_INIT > multiple times for this reset effect; I just didn't realize it > was possible when I wrote the original reset code. > > When kvm64.c grows support for system registers we can probably > coalesce the two kvm_arm_reset_cpu() functions into one. > > I also have a vague recollection that somebody reported that > we had an actual bug in this area that this patch would fix; > however I can't now find that in the mailing list archives :-( I did: http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03131.html > > Testing appreciated: my ARMv7 box is being a bit flaky at the > moment; I don't *think* the occasional weird stuff I see is > the effect of this patch but it's hard to be certain. I will test your patch in the following days. Diana