From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Alexander Graf <agraf@suse.de>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support
Date: Fri, 27 Jun 2014 09:53:19 +0200 [thread overview]
Message-ID: <53AD22EF.6050507@de.ibm.com> (raw)
In-Reply-To: <53AC3147.1090209@suse.de>
On 26/06/14 16:42, Alexander Graf wrote:
>
> On 26.06.14 16:29, Jens Freimann wrote:
>> Conny, Alex, Christian,
>>
>> here are some fixes for the s390-ccw bios. It's a mixture of
>> additional features (DASD IPL support for different formats)
>> and cleanups.
>
> From a quick glimpse it looks quite clean and straight forward, but I'd like to make sure we get rid completely of the static sector size assumption.
Should be. I guess s/SECTOR_SIZE/MAX_SECTOR_SIZE/g would be ok for you then?
>
> Also, are we guaranteed that virtio always uses 512 byte block size? Or was that just an internal API thing?
The virtio-blk API always talks in 512 byte sectors, no matter the block size.
Overall this is a nice improvement of the boot code - if possible I would like to see that in 2.1.
Conny, can you carry that in your tree (with s/SECTOR_SIZE/MAX_SECTOR_SIZE/g)?
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
for the series.
Christian
next prev parent reply other threads:[~2014-06-27 7:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 14:29 [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support Jens Freimann
2014-06-26 14:30 ` [Qemu-devel] [PATCH 01/10] pc-bios/s390-ccw: make checkpatch happy Jens Freimann
2014-06-26 14:30 ` [Qemu-devel] [PATCH 02/10] pc-bios/s390-ccw: cleanup and enhance bootmap defintions Jens Freimann
2014-06-26 14:30 ` [Qemu-devel] [PATCH 03/10] pc-bios/s390-ccw: handle different sector sizes Jens Freimann
2014-06-26 14:35 ` Alexander Graf
2014-06-26 15:08 ` Eugene "jno" Dvurechenski
2014-06-26 15:10 ` Alexander Graf
2014-06-26 14:30 ` [Qemu-devel] [PATCH 04/10] pc-bios/s390-ccw: add some utility code Jens Freimann
2014-06-26 14:30 ` [Qemu-devel] [PATCH 05/10] pc-bios/s390-ccw: Unify error handling Jens Freimann
2014-06-26 14:30 ` [Qemu-devel] [PATCH 06/10] pc-bios/s390-ccw: Add fill_hex_val func to provide better msgs Jens Freimann
2014-06-26 14:30 ` [Qemu-devel] [PATCH 07/10] pc-bios/s390-ccw: factor out ipl code Jens Freimann
2014-06-26 14:30 ` [Qemu-devel] [PATCH 08/10] pc-bios/s390-ccw: IPL from CDL-formatted ECKD DASD Jens Freimann
2014-06-26 14:30 ` [Qemu-devel] [PATCH 09/10] pc-bios/s390-ccw: IPL from LDL/CMS-formatted " Jens Freimann
2014-06-26 14:30 ` [Qemu-devel] [PATCH 10/10] pc-bios/s390-ccw: update binary Jens Freimann
2014-06-26 14:42 ` [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support Alexander Graf
2014-06-27 7:53 ` Christian Borntraeger [this message]
2014-06-27 9:05 ` Alexander Graf
2014-06-27 9:27 ` Christian Borntraeger
2014-06-27 9:47 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD22EF.6050507@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.