From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock Date: Fri, 27 Jun 2014 10:54:04 +0200 Message-ID: <53AD312C.90005@collabora.co.uk> References: <1403806546-31122-1-git-send-email-javier.martinez@collabora.co.uk> <1403806546-31122-4-git-send-email-javier.martinez@collabora.co.uk> <53AD21E5.1030609@suse.de> <53AD22ED.5040303@collabora.co.uk> <53AD2AB7.1090000@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <53AD2AB7.1090000-l3A5Bk7waGM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Lee Jones Cc: Samuel Ortiz , Mark Brown , Mike Turquette , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Sjoerd Simons , Daniel Stone , Tomeu Vizoso , Krzysztof Kozlowski , Yadwinder Singh Brar , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org Hello Andreas, On 06/27/2014 10:26 AM, Andreas F=E4rber wrote: > Hi Javier, >=20 > Am 27.06.2014 09:53, schrieb Javier Martinez Canillas: >> Hello Andreas, >>=20 >> On 06/27/2014 09:48 AM, Andreas F=E4rber wrote: >>> Am 26.06.2014 20:15, schrieb Javier Martinez Canillas: >>>> This patch adds a dt-binding include for Maxim 77686 >>>> PMIC clock IDs that can be to be shared between the >>> >>> "can be shared"? >>> >>=20 >> As it should be quite clear right now I'm not a native English speak= er. >=20 > Guessed so, me neither. But since it's v5 already and no native speak= er > pointed it out, I took the liberty to do so while verifying that the > LD02 typo didn't propagate into your bindings documentation (it didn'= t). >=20 >> I meant >> that the header file can be included by both Device Tree source file= s and the >> max77802 driver. >=20 > AFAIU "clock IDs to be shared" and "clock IDs that can be shared" wou= ld > both be valid, but above a verb is missing (e.g., "can be used to"). >=20 > Thanks for your upstreaming efforts, and don't let me discourage you. >=20 No discourage at all, your feedback is highly appreciated and sorry tha= t I didn't catch all these typos when working on the DT documentation. > Best regards, >=20 > Andreas >=20 Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) Date: Fri, 27 Jun 2014 10:54:04 +0200 Subject: [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock In-Reply-To: <53AD2AB7.1090000@suse.de> References: <1403806546-31122-1-git-send-email-javier.martinez@collabora.co.uk> <1403806546-31122-4-git-send-email-javier.martinez@collabora.co.uk> <53AD21E5.1030609@suse.de> <53AD22ED.5040303@collabora.co.uk> <53AD2AB7.1090000@suse.de> Message-ID: <53AD312C.90005@collabora.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Andreas, On 06/27/2014 10:26 AM, Andreas F?rber wrote: > Hi Javier, > > Am 27.06.2014 09:53, schrieb Javier Martinez Canillas: >> Hello Andreas, >> >> On 06/27/2014 09:48 AM, Andreas F?rber wrote: >>> Am 26.06.2014 20:15, schrieb Javier Martinez Canillas: >>>> This patch adds a dt-binding include for Maxim 77686 >>>> PMIC clock IDs that can be to be shared between the >>> >>> "can be shared"? >>> >> >> As it should be quite clear right now I'm not a native English speaker. > > Guessed so, me neither. But since it's v5 already and no native speaker > pointed it out, I took the liberty to do so while verifying that the > LD02 typo didn't propagate into your bindings documentation (it didn't). > >> I meant >> that the header file can be included by both Device Tree source files and the >> max77802 driver. > > AFAIU "clock IDs to be shared" and "clock IDs that can be shared" would > both be valid, but above a verb is missing (e.g., "can be used to"). > > Thanks for your upstreaming efforts, and don't let me discourage you. > No discourage at all, your feedback is highly appreciated and sorry that I didn't catch all these typos when working on the DT documentation. > Best regards, > > Andreas > Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752951AbaF0IyR (ORCPT ); Fri, 27 Jun 2014 04:54:17 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:33804 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbaF0IyP (ORCPT ); Fri, 27 Jun 2014 04:54:15 -0400 Message-ID: <53AD312C.90005@collabora.co.uk> Date: Fri, 27 Jun 2014 10:54:04 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Lee Jones CC: Samuel Ortiz , Mark Brown , Mike Turquette , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Sjoerd Simons , Daniel Stone , Tomeu Vizoso , Krzysztof Kozlowski , Yadwinder Singh Brar , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock References: <1403806546-31122-1-git-send-email-javier.martinez@collabora.co.uk> <1403806546-31122-4-git-send-email-javier.martinez@collabora.co.uk> <53AD21E5.1030609@suse.de> <53AD22ED.5040303@collabora.co.uk> <53AD2AB7.1090000@suse.de> In-Reply-To: <53AD2AB7.1090000@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andreas, On 06/27/2014 10:26 AM, Andreas Färber wrote: > Hi Javier, > > Am 27.06.2014 09:53, schrieb Javier Martinez Canillas: >> Hello Andreas, >> >> On 06/27/2014 09:48 AM, Andreas Färber wrote: >>> Am 26.06.2014 20:15, schrieb Javier Martinez Canillas: >>>> This patch adds a dt-binding include for Maxim 77686 >>>> PMIC clock IDs that can be to be shared between the >>> >>> "can be shared"? >>> >> >> As it should be quite clear right now I'm not a native English speaker. > > Guessed so, me neither. But since it's v5 already and no native speaker > pointed it out, I took the liberty to do so while verifying that the > LD02 typo didn't propagate into your bindings documentation (it didn't). > >> I meant >> that the header file can be included by both Device Tree source files and the >> max77802 driver. > > AFAIU "clock IDs to be shared" and "clock IDs that can be shared" would > both be valid, but above a verb is missing (e.g., "can be used to"). > > Thanks for your upstreaming efforts, and don't let me discourage you. > No discourage at all, your feedback is highly appreciated and sorry that I didn't catch all these typos when working on the DT documentation. > Best regards, > > Andreas > Best regards, Javier