From: Paolo Bonzini <pbonzini@redhat.com>
To: Reza Jelveh <reza.jelveh@gmail.com>, qemu-devel@nongnu.org
Cc: Reza Jelveh <reza.jelveh@tuhh.de>
Subject: Re: [Qemu-devel] [PATCH] ahci.c: mask the interrupt on complete flag to allow ahci.c to read the correct size for the PRDT
Date: Fri, 27 Jun 2014 13:35:31 +0200 [thread overview]
Message-ID: <53AD5703.9070005@redhat.com> (raw)
In-Reply-To: <1403825329-21942-1-git-send-email-reza.jelveh@tuhh.de>
Il 27/06/2014 01:28, Reza Jelveh ha scritto:
> +static int prdt_tbl_entry_size(const AHCI_SG tbl) {
> + return (le32_to_cpu(tbl.flags_size) & AHCI_PRDT_SIZE_MASK) + 1;
> +}
Apart from the incorrect indentation/formatting here, the patch seems okay.
How can this be reproduced?
Paolo
next prev parent reply other threads:[~2014-06-27 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 23:28 [Qemu-devel] [PATCH] ahci.c: mask the interrupt on complete flag to allow ahci.c to read the correct size for the PRDT Reza Jelveh
2014-06-27 11:35 ` Paolo Bonzini [this message]
2014-06-27 15:23 ` John Snow
2014-06-27 16:19 ` Alexander Graf
2014-06-27 16:33 ` Reza Jelveh
2014-06-27 16:38 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD5703.9070005@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=reza.jelveh@gmail.com \
--cc=reza.jelveh@tuhh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.