All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "De Lara Guarch,
	Pablo"
	<pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"dev-VfR2kkLFssw@public.gmane.org"
	<dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH] string: fix potential seg fault on snprintf
Date: Fri, 27 Jun 2014 14:34:27 +0200	[thread overview]
Message-ID: <53AD64D3.9000100@6wind.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8971A790399-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>

Hi Pablo,

On 06/27/2014 02:13 PM, De Lara Guarch, Pablo wrote:
> With last Thomas' patch, cmdline unit test does not pass due to this problem (basically it tests this situation).
> After test passed, by fixing this issue in several functions, I looked for other places where this happened.

Indeed I missed the unit test, thanks.

I think that testing the NULL case is not required. To me, it is like
testing snprintf(NULL, ...)

Regards,
Olivier

  parent reply	other threads:[~2014-06-27 12:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 11:04 [PATCH] string: fix potential seg fault on snprintf Pablo de Lara
     [not found] ` <1403867097-18848-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-27 11:30   ` Olivier MATZ
     [not found]     ` <53AD55BB.8090807-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-27 12:13       ` De Lara Guarch, Pablo
     [not found]         ` <E115CCD9D858EF4F90C690B0DCB4D8971A790399-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-27 12:34           ` Olivier MATZ [this message]
     [not found]             ` <53AD64D3.9000100-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-27 16:36               ` Richardson, Bruce
     [not found]                 ` <59AF69C657FD0841A61C55336867B5B02CF0DEA1-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-30  7:41                   ` Olivier MATZ
     [not found]                     ` <53B114C5.2050608-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-30 16:48                       ` Richardson, Bruce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AD64D3.9000100@6wind.com \
    --to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.