All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Paul Moore <paul@paul-moore.com>
Cc: Jaejyn Shin <flagon22bass@gmail.com>, selinux <selinux@tycho.nsa.gov>
Subject: Re: Fwd: Booting time is increased after applying kernel 3.10
Date: Fri, 27 Jun 2014 08:52:40 -0400	[thread overview]
Message-ID: <53AD6918.8090902@tycho.nsa.gov> (raw)
In-Reply-To: <53AD6072.6070608@tycho.nsa.gov>

On 06/27/2014 08:15 AM, Stephen Smalley wrote:
> On 06/26/2014 10:17 AM, Paul Moore wrote:
>> On Thursday, June 26, 2014 09:57:57 AM Stephen Smalley wrote:
>>> On 06/25/2014 03:49 PM, Stephen Smalley wrote:
>>>> I suspect it won't matter in practice, but the reason for it is that
>>>> permissions or other state may have been cached during bootup prior to
>>>> initial policy load that may no longer be valid.
>>
>> ...
>>
>>> So I am not sure we can safely remove the avc_ss_reset() from initial
>>> policy load in the mainline kernel, as we are not guaranteed that there
>>> is no network interface configuration prior to initial policy load and
>>> we are not guaranteed that there will be a setenforce 1.  It would
>>> perhaps be better there to instead just avoid calling synchronize_net
>>> altogether if possible or only call it once for the entire avc_ss_reset,
>>> not on each of the netif/node/port callbacks.
>>
>> When I took a quick glance at this briefly yesterday one of the things that 
>> crossed my mind was exporting the different netif/node/port flush functions 
>> and grouping the callbacks into a single callback that calls each of the flush 
>> functions and then synchronize_net() once at the end; similar to what you 
>> describe above.  Perhaps that is the best solution upstream.
>>
>> Unless someone else wants to develop/test a patch, I'll put one together.
> 
> Did you confirm that we need the synchronize_net() call at all?

Let me phrase this differently:

1) Does the synchronize_net() call guarantee that after the policy load
completes (or more specifically, after the avc_ss_reset completes), all
subsequent network permission checks will be based on the
netif/node/port contexts defined by the new policy and not based on the
old ones?

-and-

2) Does anyone currently rely on this behavior, i.e. they make a change
to the netif/node/port contexts in policy, load the new policy, and need
to know that the new context assignments are being applied on every
network operation before they can proceed safely?

  reply	other threads:[~2014-06-27 12:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAEFn6A4mzF208e1s_OHEzJ-1Kq-DUGgzVNbQXrW6NbB0e8DSpQ@mail.gmail.com>
2014-06-25 19:14 ` Fwd: Booting time is increased after applying kernel 3.10 Stephen Smalley
2014-06-25 19:29   ` Paul Moore
2014-06-25 19:49     ` Stephen Smalley
2014-06-25 23:19       ` Jaejyn Shin
2014-06-26 13:57       ` Stephen Smalley
2014-06-26 14:17         ` Paul Moore
2014-06-27 12:15           ` Stephen Smalley
2014-06-27 12:52             ` Stephen Smalley [this message]
2014-06-27 13:11               ` Paul Moore
2015-04-01 18:58 Ravi Kumar
2015-04-01 19:20 ` Stephen Smalley
2015-04-01 19:24   ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AD6918.8090902@tycho.nsa.gov \
    --to=sds@tycho.nsa.gov \
    --cc=flagon22bass@gmail.com \
    --cc=paul@paul-moore.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.