Re: [PATCH] ASoC: rt5640: add ASRC support

[Lars-Peter Clausen <lars@metafoo.de>]

On 06/27/2014 12:58 PM, bardliao@realtek.com wrote:
> From: Bard Liao <bardliao@realtek.com>
>
> This patch add ASRC support for rt5640 series codecs.
>
> Signed-off-by: Bard Liao <bardliao@realtek.com>
> ---
>   sound/soc/codecs/rt5640.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++-
>   sound/soc/codecs/rt5640.h |  2 ++
>   2 files changed, 80 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
> index 6bc6efd..3245ec4 100644
> --- a/sound/soc/codecs/rt5640.c
> +++ b/sound/soc/codecs/rt5640.c
> @@ -341,6 +341,43 @@ static bool rt5640_readable_register(struct device *dev, unsigned int reg)
>   	}
>   }
>
> +static const char * const rt5640_asrc_mode[] = {
> +	"disable", "enable"
> +};
> +
> +static const SOC_ENUM_SINGLE_DECL(rt5640_asrc_enum, SND_SOC_NOPM,
> +				0, rt5640_asrc_mode);

I wonder if that shouldn't be something that is automatically 
enabled/disabled based on the samplerates involved. Also for enable/disable 
controls use a switch control rather than a enum.

- Lars