From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v01 2/3] xen/arm: add platform specific definitions for DRA7 evm board Date: Fri, 27 Jun 2014 15:27:14 +0100 Message-ID: <53AD7F42.8050500@linaro.org> References: <1403781330-22504-1-git-send-email-andrii.tseglytskyi@globallogic.com> <1403781330-22504-3-git-send-email-andrii.tseglytskyi@globallogic.com> <1403871463.25894.63.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1403871463.25894.63.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Andrii Tseglytskyi Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 27/06/14 13:17, Ian Campbell wrote: >> + /* OMAP Linux kernel handles devices with status "disabled" in a >> + * weird manner - tries to reset them. While their memory ranges >> + * are not mapped, this leads to data aborts, so skip these devices >> + * from DT for dom0. >> + */ >> + DT_MATCH_NOT_AVAILABLE(), > > I think this should be done in common code, either by default (if that > makes sense) or using a new quirk flag. Both of these solutions doesn't make sense to me. A device which is not available should not be touch by the kernel. In most of the case, Linux ignores a device which is not available (see amba/platform register code). For instance, some board has the same SOC but with different devices enabled/disabled. In this case, there is usually a common device tree with all enabled/disabled, and a specific device tree which override some properties. If OMAP does weird thinks with the device tree, then we should keep it in the platform code. Regards, -- Julien Grall