From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0YmS-0000Xn-Bo for qemu-devel@nongnu.org; Fri, 27 Jun 2014 12:13:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0YmJ-0006Xr-Ul for qemu-devel@nongnu.org; Fri, 27 Jun 2014 12:13:40 -0400 Message-ID: <53AD9829.8050908@suse.de> Date: Fri, 27 Jun 2014 18:13:29 +0200 From: Alexander Graf MIME-Version: 1.0 References: <20140627134737.26170.27909.stgit@nimbus> <20140627171632.17b0ff18@bahia.local> In-Reply-To: <20140627171632.17b0ff18@bahia.local> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-ppc: KVMPPC_H_CAS fix cpu-version endianess List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz , Laurent Dufour Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 27.06.14 17:16, Greg Kurz wrote: > On Fri, 27 Jun 2014 15:47:37 +0200 > Laurent Dufour wrote: > >> During KVMPPC_H_CAS processing, the cpu-version updated value is stored >> without taking care of the current endianess. As a consequence, the guest >> may not switch to the right CPU model, leading to unexpected results. >> >> If needed, the value is now converted. >> >> Fixes: 6d9412ea8132 ("target-ppc: Implement "compat" CPU option") >> Signed-off-by: Laurent Dufour >> --- > Reviewed-by: Greg Kurz Good catch! Thanks, applied to ppc-next. Alex