From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Wolfgang Grandegger <wg@grandegger.com>,
Jason R1 White <White_Jason_R1@cat.com>
Cc: linux-can@vger.kernel.org, linux-can-owner@vger.kernel.org
Subject: Re: Bus off
Date: Fri, 27 Jun 2014 19:34:39 +0200 [thread overview]
Message-ID: <53ADAB2F.5030902@hartkopp.net> (raw)
In-Reply-To: <53AD9BA1.1030801@grandegger.com>
On 27.06.2014 18:28, Wolfgang Grandegger wrote:
> On 06/27/2014 05:45 PM, Jason R1 White wrote:
>> So is it still the recommendation to close the interface to flush the
>> queues?
>
> As I said: the purpose of "restart" is not to do a fast if down->up.
>
>> Is there anything planned for an ip command or IOCTL to do this?
>
> It's on the wish list, let's say. Somebody needs to implement it. It's
> also not straight-forward because there might be more than one socket
> sending out CAN messages. For standard network devices there is no way
> to flush all TX queues, IIRC.
Probably shutting down the netdevice at BUS_OFF would be an alternative to
restart-ms. When the netdevice is down all sockets are notified by -ENETDOWN.
We would need some kind of notification when frames got lost anyway. And after
-ENETDOWN the application can recover and set up it's communication again.
Regards,
Oliver
next prev parent reply other threads:[~2014-06-27 17:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 17:13 Bus off Austin Schuh
2014-06-26 22:54 ` Max S.
2014-06-27 7:04 ` Marc Kleine-Budde
2014-06-27 5:05 ` Kurt Van Dijck
2014-06-27 15:22 ` Jason R1 White
2014-06-27 15:35 ` Wolfgang Grandegger
2014-06-27 15:45 ` Jason R1 White
2014-06-27 15:50 ` Marc Kleine-Budde
2014-06-27 16:28 ` Wolfgang Grandegger
2014-06-27 17:34 ` Oliver Hartkopp [this message]
2014-06-28 1:29 ` Austin Schuh
2014-06-28 8:52 ` Wolfgang Grandegger
2014-06-28 18:48 ` Austin Schuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ADAB2F.5030902@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=White_Jason_R1@cat.com \
--cc=linux-can-owner@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.