From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Etheridge Subject: Re: [PATCH/RESEND 0/9] drm: tilcdc driver fixes Date: Fri, 27 Jun 2014 17:08:51 -0500 Message-ID: <53ADEB73.8090301@ti.com> References: <1402110128-30471-1-git-send-email-guido@vanguardiasur.com.ar> <1403014631-18072-1-git-send-email-guido@vanguardiasur.com.ar> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1403014631-18072-1-git-send-email-guido@vanguardiasur.com.ar> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?R3VpZG8gTWFydMOtbmV6?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Cc: Daniel Vetter , Russell King , =?UTF-8?B?RXplcXVpZWwgR2FyY8OtYQ==?= , Daniel Mack List-Id: linux-omap@vger.kernel.org R3VpZG8sCgpPbiAwNi8xNy8yMDE0IDA5OjE3IEFNLCBHdWlkbyBNYXJ0w61uZXogd3JvdGU6Cj4g VGhlIHRpbGNkYyBkcml2ZXIgY291bGQgYmUgY29tcGlsZWQgYXMgYSBtb2R1bGUsIGJ1dCB3YXMg c2V2ZXJlbHkgYnJva2VuCj4gYW5kIGNvdWxkIG5vdCBiZSB1c2VkIGFzIHN1Y2guIFRoaXMgcGF0 Y2hzZXQgYXR0ZW1wdHMgdG8gZml4IHRoZSBpc3N1ZXMKPiBwcmV2ZW50aW5nIGEgcHJvcGVyIGxv YWQvdW5sb2FkIG9mIHRoZSBtb2R1bGUuCj4KPiBJc3N1ZXMgaW5jbHVkZWQgZGFuZ2xpbmcgc3lz ZnMgbm9kZXMsIGRhbmdsaW5nIGRldmljZXMsIG1lbW9yeSBsZWFrcyBhbmQKPiBhIGRvdWJsZSBr ZnJlZS4KPgo+IEl0IG5vdyBzZWVtcyB0byBiZSB3b3JraW5nIG9rLiBXZSBoYXZlIHRlc3RlZCB0 aGlzIGJ5IGxvYWRpbmcgYW5kCj4gdW5sb2FkaW5nIHRoZSBkcml2ZXIgcmVwZXRlYWRseSwgd2l0 aCBib3RoIHBhbmVsIGFuZCBzbGF2ZSBjb25uZWN0b3JzCj4gYW5kIGZvdW5kIG5vIGZsYXdzLgo+ Cj4gVGhlcmUgaXMgc3RpbGwgb25lIHdhcm5pbmcgbGVmdCBvbiB0aWxjZGNfY3J0Y19kZXN0cm95 LCBjYXVzZWQgYnkKPiBkZXN0cm95aW5nIHRoZSBjb25uZWN0b3Igd2hpbGUgc3RpbGwgaW4gYW4g T04gc3RhdHVzLiBXZSBkb24ndCBrbm93IHdoeQo+IHRoaXMgaGFwcGVucyBvciB3aHkgaXQncyBh biBpc3N1ZSwgc28gd2UgZGlkIG5vdCBmaXggaXQuCj4KClllcyBJIHNlZSB3aGF0IHlvdSBtZWFu LCBpdCB0cmlnZ2VycyB0aGUgV0FSTl9PTiBpbiB0aWxjZGNfY3J0Y19kZXN0cm95IApiZWNhdXNl IERSTV9NT0RFX0RQTVNfT04gaXMgc3RpbGwgc2V0LiAgVGhpcyBXQVJOX09OIGRvZXMgbWFrZSBz b21lIApzZW5zZSBiZWNhdXNlIERQTVNfT0ZGIHdvdWxkIGhhdmUgdGhlIGVmZmVjdCBvZiB0dXJu aW5nIG9mZiBjbG9ja3MgYW5kIApwdXR0aW5nIHRoZSBtb25pdG9yIHRvIHNsZWVwIHdoaWNoIHNl ZW1zIGxvZ2ljYWwgY29uc2lkZXJpbmcgd2UgaGF2ZSAKdG9ybiBkb3duIHRoZSBkaXNwbGF5LiAg QWRkaW5nIGEgdGlsY2RjX2NydGNfZHBtcyhEUE1TX09GRikgcmlnaHQgYmVmb3JlIAp0aGUgV0FS Tl9PTiBjb25maXJtcyB0aGlzLCBidXQgaXQgc2VlbXMgc3RyYW5nZSB0aGF0IHRoaXMgaGFzbid0 IApoYXBwZW5lZCBhdXRvbWF0aWNhbGx5ICgrIFJ1c3NlbGwgZG9lc24ndCBuZWVkIHRvIGRvIGl0 IGluIGhpcyBBcm1hZGEgCmRyaXZlcikgLSBzbyBJIHN1c3BlY3QgdGhlcmUgaXMgYSBiZXR0ZXIg d2F5LgoKT3RoZXJ3aXNlIEkgdGhpbmsgdGhpcyBpcyBhIGdvb2QgYW5kIHVzZWZ1bCBwYXRjaCBz ZXJpZXMuCgpEYXJyZW4KCj4gVGhlIGZpcnN0IDcgcGF0Y2hlcyBhcmUgYnVnIGZpeGVzIHdoaWNo IGFuZCBzaG91bGQgcHJvYmFibHkgYmUgYXBwbGllZAo+IGluIHRoZSBzdGFibGUgdHJlZXMuIFRo ZSBsYXN0IHR3byBhcmUgY2xlYW4tdXBzLgo+Cj4KPiBSZXNlbmRpbmcgdGhpcyBzaW5jZSBJIGdv dCBubyByZXBsaWVzLgo+Cj4KPiBHdWlkbyBNYXJ0w61uZXogKDkpOgo+ICAgIGRybS9pMmM6IHRk YTk5OHg6IG1vdmUgZHJtX2kyY19lbmNvZGVyX2Rlc3Ryb3kgY2FsbAo+ICAgIGRybS90aWxjZGM6 IHBhbmVsOiBmaXggZGFuZ2xpbmcgc3lzZnMgY29ubmVjdG9yIG5vZGUKPiAgICBkcm0vdGlsY2Rj OiBzbGF2ZTogZml4IGRhbmdsaW5nIHN5c2ZzIGNvbm5lY3RvciBub2RlCj4gICAgZHJtL3RpbGNk YzogdGZwNDEwOiBmaXggZGFuZ2xpbmcgc3lzZnMgY29ubmVjdG9yIG5vZGUKPiAgICBkcm0vdGls Y2RjOiBwYW5lbDogZml4IGxlYWsgd2hlbiB1bmxvYWRpbmcgdGhlIG1vZHVsZQo+ICAgIGRybS90 aWxjZGM6IGZpeCByZWxlYXNlIG9yZGVyIG9uIGV4aXQKPiAgICBkcm0vdGlsY2RjOiBmaXggZG91 YmxlIGtmcmVlCj4gICAgZHJtL3RpbGNkYzogcmVtb3ZlIHN1Ym1vZHVsZSBkZXN0cm95IGNhbGxz Cj4gICAgZHJtL3RpbGNkYzogcmVwbGFjZSBsYXRlX2luaXRjYWxsIHdpdGggbW9kdWxlX2luaXQK Pgo+ICAgZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jICAgICAgfCAgMiArLQo+ICAg ZHJpdmVycy9ncHUvZHJtL3RpbGNkYy9Nb2R1bGUuc3ltdmVycyAgfCAgMAo+ICAgZHJpdmVycy9n cHUvZHJtL3RpbGNkYy90aWxjZGNfZHJ2LmMgICAgfCAxNSArKysrKy0tLS0tLS0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19kcnYuaCAgICB8ICAxIC0KPiAgIGRyaXZlcnMvZ3B1 L2RybS90aWxjZGMvdGlsY2RjX3BhbmVsLmMgIHwgMzkgKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90aWxjZGNfc2xhdmUuYyAgfCAy NyArKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90aWxj ZGNfdGZwNDEwLmMgfCAzNSArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgIDcgZmls ZXMgY2hhbmdlZCwgNTkgaW5zZXJ0aW9ucygrKSwgNjAgZGVsZXRpb25zKC0pCj4gICBjcmVhdGUg bW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL3RpbGNkYy9Nb2R1bGUuc3ltdmVycwo+Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: detheridge@ti.com (Darren Etheridge) Date: Fri, 27 Jun 2014 17:08:51 -0500 Subject: [PATCH/RESEND 0/9] drm: tilcdc driver fixes In-Reply-To: <1403014631-18072-1-git-send-email-guido@vanguardiasur.com.ar> References: <1402110128-30471-1-git-send-email-guido@vanguardiasur.com.ar> <1403014631-18072-1-git-send-email-guido@vanguardiasur.com.ar> Message-ID: <53ADEB73.8090301@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Guido, On 06/17/2014 09:17 AM, Guido Mart?nez wrote: > The tilcdc driver could be compiled as a module, but was severely broken > and could not be used as such. This patchset attempts to fix the issues > preventing a proper load/unload of the module. > > Issues included dangling sysfs nodes, dangling devices, memory leaks and > a double kfree. > > It now seems to be working ok. We have tested this by loading and > unloading the driver repeteadly, with both panel and slave connectors > and found no flaws. > > There is still one warning left on tilcdc_crtc_destroy, caused by > destroying the connector while still in an ON status. We don't know why > this happens or why it's an issue, so we did not fix it. > Yes I see what you mean, it triggers the WARN_ON in tilcdc_crtc_destroy because DRM_MODE_DPMS_ON is still set. This WARN_ON does make some sense because DPMS_OFF would have the effect of turning off clocks and putting the monitor to sleep which seems logical considering we have torn down the display. Adding a tilcdc_crtc_dpms(DPMS_OFF) right before the WARN_ON confirms this, but it seems strange that this hasn't happened automatically (+ Russell doesn't need to do it in his Armada driver) - so I suspect there is a better way. Otherwise I think this is a good and useful patch series. Darren > The first 7 patches are bug fixes which and should probably be applied > in the stable trees. The last two are clean-ups. > > > Resending this since I got no replies. > > > Guido Mart?nez (9): > drm/i2c: tda998x: move drm_i2c_encoder_destroy call > drm/tilcdc: panel: fix dangling sysfs connector node > drm/tilcdc: slave: fix dangling sysfs connector node > drm/tilcdc: tfp410: fix dangling sysfs connector node > drm/tilcdc: panel: fix leak when unloading the module > drm/tilcdc: fix release order on exit > drm/tilcdc: fix double kfree > drm/tilcdc: remove submodule destroy calls > drm/tilcdc: replace late_initcall with module_init > > drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- > drivers/gpu/drm/tilcdc/Module.symvers | 0 > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 15 +++++-------- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 1 - > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 39 +++++++++++++++++----------------- > drivers/gpu/drm/tilcdc/tilcdc_slave.c | 27 +++++++++++++---------- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 35 +++++++++++++++--------------- > 7 files changed, 59 insertions(+), 60 deletions(-) > create mode 100644 drivers/gpu/drm/tilcdc/Module.symvers >