All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: <linux-btrfs@vger.kernel.org>, <mfasheh@suse.de>
Subject: Re: [PATCH] Btrfs: make sure to use btrfs_header_owner when freeing tree block V2
Date: Fri, 27 Jun 2014 17:16:53 -0700	[thread overview]
Message-ID: <53AE0975.1030202@fb.com> (raw)
In-Reply-To: <1403913903-21132-1-git-send-email-jbacik@fb.com>

On 06/27/2014 05:05 PM, Josef Bacik wrote:
> Mark noticed that his qgroup accounting for snapshot deletion wasn't working
> properly on a particular file system.  Turns out we pass the root->objectid of
> the root we are deleting to btrfs_free_extent, and use that root always when we
> call btrfs_free_tree_block.  This isn't correct, the owner must match the
> btrfs_header_owner() of the eb.  So to fix this we need to use that when we call
> btrfs_free_extent, and we also need to use btrfs_header_owner(eb) in
> btrfs_free_tree_block as the root we pass in may not be the owner in the case of
> snapshot delete (though it is for all the normal cases which is why it wasn't
> noticed before.)  With this patch on top of Mark's snapshot delete patch
> everything is working a-ok.  Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> ---
> V1->V2: this one actually compiles.
>

Huh I may be completely full of crap here, let's just ignore all post 5pm Friday patches from me for now.  Thanks,

Josef


      reply	other threads:[~2014-06-28  0:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-28  0:05 [PATCH] Btrfs: make sure to use btrfs_header_owner when freeing tree block V2 Josef Bacik
2014-06-28  0:16 ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AE0975.1030202@fb.com \
    --to=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=mfasheh@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.