From: Jens Axboe <axboe@kernel.dk>
To: Andrey Kuzmin <andrey.v.kuzmin@gmail.com>
Cc: fio@vger.kernel.org
Subject: Re: A typo in io_u.c::get_next_file()?
Date: Fri, 27 Jun 2014 20:22:44 -0600 [thread overview]
Message-ID: <53AE26F4.9050808@kernel.dk> (raw)
In-Reply-To: <CANvN+ekEc4AW+0WcC2YwmJdXA4WO_APSqPQkhq5oexOdrD+UXw@mail.gmail.com>
On 2014-06-27 18:54, Andrey Kuzmin wrote:
> diff --git a/io_u.c b/io_u.c
> index e132fd9..f487b0a 100644
> --- a/io_u.c
> +++ b/io_u.c
> @@ -1100,7 +1100,7 @@ out:
>
> static struct fio_file *get_next_file(struct thread_data *td)
> {
> - if (!(td->flags & TD_F_PROFILE_OPS)) {
> + if ((td->flags & TD_F_PROFILE_OPS)) {
> struct prof_io_ops *ops = &td->prof_io_ops;
>
> if (ops->get_next_file)
Hah indeed, good catch! I was wondering why it would not segfault, but I
guess we fall through normally anyway. So it only impacts profiles that
have get_next_file set, which makes it a minor issue.
Thanks for the patch! Applied.
--
Jens Axboe
next prev parent reply other threads:[~2014-06-28 2:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 0:54 A typo in io_u.c::get_next_file()? Andrey Kuzmin
2014-06-28 2:22 ` Jens Axboe [this message]
2014-06-28 3:55 ` Andrey Kuzmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AE26F4.9050808@kernel.dk \
--to=axboe@kernel.dk \
--cc=andrey.v.kuzmin@gmail.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.