All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] iio: core: add xyz modifier value
Date: Sat, 28 Jun 2014 09:35:09 +0100	[thread overview]
Message-ID: <53AE7E3D.70807@kernel.org> (raw)
In-Reply-To: <1403829626-17660-2-git-send-email-srinivas.pandruvada@linux.intel.com>

On 27/06/14 01:40, Srinivas Pandruvada wrote:
> iio types defines a modifier called IIO_MOD_X_AND_Y_AND_Z, but since
> no modifier name is specified, it shows (null) as channel name.
> Here name is assiged a value "xyz".
Hmm. The purpose of this particularly modifier was for boolean combinations
of events.  There are devices out there that will only fire an interrupt
if say they detect changes in acceleration in all 3 directions...
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>   drivers/iio/industrialio-core.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 4b1f375..e8428bb 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -87,6 +87,7 @@ static const char * const iio_modifier_names[] = {
>   	[IIO_MOD_QUATERNION] = "quaternion",
>   	[IIO_MOD_TEMP_AMBIENT] = "ambient",
>   	[IIO_MOD_TEMP_OBJECT] = "object",
> +	[IIO_MOD_X_AND_Y_AND_Z] = "xyz",
>   };
>
>   /* relies on pairs of these shared then separate */
>


  parent reply	other threads:[~2014-06-28  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27  0:40 [RFC PATCH 0/2] raw read performance improvement Srinivas Pandruvada
2014-06-27  0:40 ` [RFC PATCH 1/2] iio: core: add xyz modifier value Srinivas Pandruvada
2014-06-27  7:44   ` Daniel Baluta
2014-06-28  8:35   ` Jonathan Cameron [this message]
2014-06-27  0:40 ` [RFC PATCH 2/2] iio: magnetometer: ak8975: Improve performance of raw reads Srinivas Pandruvada
2014-06-28  8:49 ` [RFC PATCH 0/2] raw read performance improvement Jonathan Cameron
2014-06-28 13:16   ` Srinivas Pandruvada
2014-06-28 14:14     ` Jonathan Cameron
2014-06-28 16:46       ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AE7E3D.70807@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.