From: Nishanth Menon <nm@ti.com>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: Kevin Hilman <khilman@kernel.org>,
linux-pm@vger.kernel.org, linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/1] drivers/power/avs/smartreflex.c: remove unnecessary null test before debugfs_remove_recursive
Date: Sat, 28 Jun 2014 08:36:23 -0500 [thread overview]
Message-ID: <53AEC4D7.50205@ti.com> (raw)
In-Reply-To: <1403958799-4692-1-git-send-email-fabf@skynet.be>
Minor fix of $subject to be inline with existing logs needed.
PM / AVS: SmartReflex: ..
On 06/28/2014 07:33 AM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
>
> Cc: Kevin Hilman <khilman@kernel.org>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/power/avs/smartreflex.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index db9973b..ecc5979 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -1001,8 +1001,7 @@ static int omap_sr_remove(struct platform_device *pdev)
>
> if (sr_info->autocomp_active)
> sr_stop_vddautocomp(sr_info);
> - if (sr_info->dbg_dir)
> - debugfs_remove_recursive(sr_info->dbg_dir);
> + debugfs_remove_recursive(sr_info->dbg_dir);
>
> pm_runtime_disable(&pdev->dev);
> list_del(&sr_info->node);
>
Acked-by: Nishanth Menon <nm@ti.com>
prev parent reply other threads:[~2014-06-28 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 12:33 [PATCH 1/1] drivers/power/avs/smartreflex.c: remove unnecessary null test before debugfs_remove_recursive Fabian Frederick
2014-06-28 13:36 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AEC4D7.50205@ti.com \
--to=nm@ti.com \
--cc=fabf@skynet.be \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.