From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 7548CE00510; Sat, 28 Jun 2014 08:48:27 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.220.48 listed in list.dnswl.org] Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 53343E003D6 for ; Sat, 28 Jun 2014 08:48:18 -0700 (PDT) Received: by mail-pa0-f48.google.com with SMTP id et14so6120787pad.35 for ; Sat, 28 Jun 2014 08:48:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=QS7vEsUNYJB7lUYAWoFPUV6TRqESX9NgH5C/mU7jIOU=; b=jO7CZ8TqiDuHohr6uL0QubqcYewivoUoSSvHmDiXcoLlnWijLudmL2jYQaMbtiEQ8i esDhGuBbbDDyO0SKQkHkVOO9vX5Zam1ZSaSwepbOpijafkLH/z62Czcwor6+DAXrpwl+ 5QVdeXaUru7UO8pVCSS2IDad841Wz3p5s+swXwJzELQ79i4EFZPQA3TUyxKBwcAkG6mJ 5jGAbrLU+aoGCkjBraEwaTzG6GHANzzNh7DsgZ60ivuYLNrv0J3a6AXKYydIvvDCDvV2 COl1aeAliYLnFUSDKAEJmRaXEQdc95ymFHY5DzZ1H+S/+kZqUcuz/oygr1rYVf3eBmAQ NGgQ== X-Gm-Message-State: ALoCoQkweGJZBmH8U2Jo9Npp95dUpaV16a5kmftbKc23hvYKF2C5m1x2FD6LYyTRtT06kLTPOCkx X-Received: by 10.68.130.130 with SMTP id oe2mr39546233pbb.154.1403970497800; Sat, 28 Jun 2014 08:48:17 -0700 (PDT) Received: from [192.168.1.7] (ip98-165-103-37.ph.ph.cox.net. [98.165.103.37]) by mx.google.com with ESMTPSA id uj2sm69419022pab.14.2014.06.28.08.48.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 28 Jun 2014 08:48:16 -0700 (PDT) Message-ID: <53AEE3BD.1050309@boundarydevices.com> Date: Sat, 28 Jun 2014 08:48:13 -0700 From: Eric Nelson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Lauren Post , "meta-freescale@yoctoproject.org" References: <1403373168-4986-1-git-send-email-eric.nelson@boundarydevices.com> In-Reply-To: X-Enigmail-Version: 1.6 Subject: Re: [meta-fsl-arm][PATCH] imx-vpu: fix checks of IOGetVirtMem() return value X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jun 2014 15:48:27 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thanks Lauren. On 06/28/2014 07:45 AM, Lauren Post wrote: > The patch is good. Team said they'll push it into our upcoming beta release. > > -----Original Message----- > From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Eric Nelson > Sent: Saturday, June 21, 2014 12:53 PM > To: meta-freescale@yoctoproject.org > Subject: [meta-freescale] [meta-fsl-arm][PATCH] imx-vpu: fix checks of IOGetVirtMem() return value > > The IOGetVirtMem() routine returns the address of a memory block or -1 (MAP_FAILED) to indicate an error. > > Many callers of this routine tested the return value for <= 0 to detect failure, and at least with a 3G/1G memory split configured in the kernel, a negative number (!= -1) is a valid (successful) return value. > > Without this patch, the IOSystemInit() will often detect failure incorrectly. > > Signed-off-by: Eric Nelson > --- > ...etVirtMem-returns-1-MAP_FAILED-on-failure.patch | 81 ++++++++++++++++++++++