From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 1EA88E00510; Sat, 28 Jun 2014 10:46:49 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [209.85.192.180 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com [209.85.192.180]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 003EFE003D6 for ; Sat, 28 Jun 2014 10:46:44 -0700 (PDT) Received: by mail-pd0-f180.google.com with SMTP id fp1so5921013pdb.25 for ; Sat, 28 Jun 2014 10:46:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=s/sVXMSUlej5dh9V43KqXvSfju8zoi1zwZcHWaFs2Ps=; b=d3EeldAQBWCxcpTtsrkuasqFhCQiwoif/qstAYHa5t5NZgyat3Qu6XB+Nhbsko0/Fw KHNTwNw+ffDB94sf3U4EkFvnSRqD0phEHh1UM8vT844/gV5kE8MlU3grAk+IYPE2F4+m QjPMvFhrOwBYmdLXJQ50Z8M79/bOLU6kMpv9ntjUWmmCZWgt3PgxFu4J3zDICft9/DIq hbgO2M9/6KdkqiZtU0fmrczCpTqt0MluyUA3eWZsTTUiY7rjnJplx9LuGZyVMWkZLQlG whJ8QwsW4YpUfxc2GW2ERRt51g+Hu0sH8Amx7ArGYSCOmABagVy9uHa+7yv/IYWXMOZl roIA== X-Gm-Message-State: ALoCoQn08BxogzfVjREoi/bGDOcwaPwG+rek5mIOmb2fiAesPNiuXP61GtQTMLY/fwZUhoZtcrj9 X-Received: by 10.66.136.131 with SMTP id qa3mr39309892pab.77.1403977604448; Sat, 28 Jun 2014 10:46:44 -0700 (PDT) Received: from [192.168.1.7] (ip98-165-103-37.ph.ph.cox.net. [98.165.103.37]) by mx.google.com with ESMTPSA id wp3sm20176869pbc.67.2014.06.28.10.46.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 28 Jun 2014 10:46:43 -0700 (PDT) Message-ID: <53AEFF7F.4080904@boundarydevices.com> Date: Sat, 28 Jun 2014 10:46:39 -0700 From: Eric Nelson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Otavio Salvador References: <1403974920-28364-1-git-send-email-eric.nelson@boundarydevices.com> <1403975852-28924-1-git-send-email-eric.nelson@boundarydevices.com> In-Reply-To: X-Enigmail-Version: 1.6 Cc: "meta-freescale@yoctoproject.org" , laci@boundarydevices.com Subject: Re: [meta-fsl-arm][PATCH V2] libfslvpuwrap_1.0.46: fix IOGetVirtMem calls X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jun 2014 17:46:49 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/28/2014 10:27 AM, Otavio Salvador wrote: > Hello Eric, > > On Sat, Jun 28, 2014 at 2:17 PM, Eric Nelson > wrote: >> Signed-off-by: Eric Nelson > ... >> +Subject: [PATCH] vpu_wrapper: fix tests of return value from IOGetVirtMem >> + >> +IOGetVirtMem() returns a pointer or specifically -1 (MAP_FAILED) >> +in the case of failure. > > Please extend the commit log with this info. This is much better to > have it in commit log instead of forcing people to find out what 'fix > calls' means ;) > Okay. I started to do that, but it felt redundant-redundant...