Re: [PATCH] FIXME of file toploogy.h for alpha cpus

[Sasha Levin <sashal@kernel.org>]

On 06/28/2014 12:07 AM, Nicholas Krause wrote:
> This patch fixs the FIXME message in the function *cpumask_of_node
> for using this function multiple times and the issue with recaluting
> the cpu node mask when reusing this function.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/alpha/include/asm/topology.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/alpha/include/asm/topology.h b/arch/alpha/include/asm/topology.h
> index 9251e13..d301f66 100644
> --- a/arch/alpha/include/asm/topology.h
> +++ b/arch/alpha/include/asm/topology.h
> @@ -31,6 +31,9 @@ static const struct cpumask *cpumask_of_node(int node)
>  	if (node == -1)
>  		return cpu_all_mask;
>  
> +	else if (node == &node_to_cpumask_map[node])
> +		return &node_to_cpumask_map[node];
> +
>  	cpumask_clear(&node_to_cpumask_map[node]);
>  
>  	for_each_online_cpu(cpu) {
> 

Since this patch doesn't even compile, care to tell us how you tested it?


Thanks,
Sasha