From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH v2 2/6] input: touchscreen: imx25 tcq driver Date: Sun, 29 Jun 2014 12:00:20 +0100 Message-ID: <53AFF1C4.1010402@kernel.org> References: <1392913312-9030-1-git-send-email-mpa@pengutronix.de> <1402672899-6995-1-git-send-email-denis@eukrea.com> <1402672899-6995-3-git-send-email-denis@eukrea.com> <53A55BD8.7030905@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabio Estevam Cc: Denis Carikli , Shawn Guo , Samuel Ortiz , Dmitry Torokhov , =?UTF-8?B?RXJpYyBCw6luYXJk?= , Sascha Hauer , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Lee Jones , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lars-Peter Clausen , Markus Pargmann List-Id: linux-input@vger.kernel.org On 21/06/14 20:55, Fabio Estevam wrote: > On Sat, Jun 21, 2014 at 7:18 AM, Jonathan Cameron wrote: >>> + >>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> >> Could this not in theory fail? > > Yes, but devm_ioremap_resource will take care of it, so we don't need > to check for error here. Nothing like counter intuitive behaviour. Ah well. Thanks for explaining this! > >> >>> + mem = devm_ioremap_resource(dev, res); >>> + if (!mem) >>> + return -ENOMEM; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.19.201]:52646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbaF2K6Q (ORCPT ); Sun, 29 Jun 2014 06:58:16 -0400 Message-ID: <53AFF1C4.1010402@kernel.org> Date: Sun, 29 Jun 2014 12:00:20 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Fabio Estevam CC: Denis Carikli , Shawn Guo , Samuel Ortiz , Dmitry Torokhov , =?UTF-8?B?RXJpYyBCw6luYXJk?= , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , Lee Jones , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, Lars-Peter Clausen , Markus Pargmann Subject: Re: [PATCH v2 2/6] input: touchscreen: imx25 tcq driver References: <1392913312-9030-1-git-send-email-mpa@pengutronix.de> <1402672899-6995-1-git-send-email-denis@eukrea.com> <1402672899-6995-3-git-send-email-denis@eukrea.com> <53A55BD8.7030905@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 21/06/14 20:55, Fabio Estevam wrote: > On Sat, Jun 21, 2014 at 7:18 AM, Jonathan Cameron wrote: >>> + >>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> >> Could this not in theory fail? > > Yes, but devm_ioremap_resource will take care of it, so we don't need > to check for error here. Nothing like counter intuitive behaviour. Ah well. Thanks for explaining this! > >> >>> + mem = devm_ioremap_resource(dev, res); >>> + if (!mem) >>> + return -ENOMEM; From mboxrd@z Thu Jan 1 00:00:00 1970 From: jic23@kernel.org (Jonathan Cameron) Date: Sun, 29 Jun 2014 12:00:20 +0100 Subject: [PATCH v2 2/6] input: touchscreen: imx25 tcq driver In-Reply-To: References: <1392913312-9030-1-git-send-email-mpa@pengutronix.de> <1402672899-6995-1-git-send-email-denis@eukrea.com> <1402672899-6995-3-git-send-email-denis@eukrea.com> <53A55BD8.7030905@kernel.org> Message-ID: <53AFF1C4.1010402@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 21/06/14 20:55, Fabio Estevam wrote: > On Sat, Jun 21, 2014 at 7:18 AM, Jonathan Cameron wrote: >>> + >>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> >> Could this not in theory fail? > > Yes, but devm_ioremap_resource will take care of it, so we don't need > to check for error here. Nothing like counter intuitive behaviour. Ah well. Thanks for explaining this! > >> >>> + mem = devm_ioremap_resource(dev, res); >>> + if (!mem) >>> + return -ENOMEM;