From: Richard Weinberger <richard@nod.at>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: donb@securitymouse.com, markus@oberhumer.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: lzo1x_decompress_safe: Macro compares unsigned to 0 (NO_EFFECT)
Date: Mon, 30 Jun 2014 09:22:47 +0200 [thread overview]
Message-ID: <53B11047.3000105@nod.at> (raw)
In-Reply-To: <53b0f0f715b96_146f12c1338333fa@209.249.196.67.mail>
This was introduced by:
commit 206a81c18401c0cde6e579164f752c4b147324ce
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Fri Jun 20 22:00:53 2014 -0700
lzo: properly check for overruns
Thanks,
//richard
-------- Original-Nachricht --------
Betreff: New Defects reported by Coverity Scan for Linux
Datum: Sun, 29 Jun 2014 22:09:11 -0700
Von: scan-admin@coverity.com
Hi,
Please find the latest report on new defect(s) introduced to Linux found with Coverity Scan.
Defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1224102: Macro compares unsigned to 0 (NO_EFFECT)
/lib/lzo/lzo1x_decompress_safe.c: 225 in lzo1x_decompress_safe()
________________________________________________________________________________________________________
*** CID 1224102: Macro compares unsigned to 0 (NO_EFFECT)
/lib/lzo/lzo1x_decompress_safe.c: 225 in lzo1x_decompress_safe()
219 op += t;
220 ip += t;
221 } else
222 #endif
223 {
224 NEED_IP(t, 3);
>>> CID 1224102: Macro compares unsigned to 0 (NO_EFFECT)
>>> This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "t + 0UL >= 0UL".
225 NEED_OP(t, 0);
226 while (t > 0) {
227 *op++ = *ip++;
228 t--;
229 }
230 }
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan.coverity.com/projects/128?tab=overview
To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py
next parent reply other threads:[~2014-06-30 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53b0f0f715b96_146f12c1338333fa@209.249.196.67.mail>
2014-06-30 7:22 ` Richard Weinberger [this message]
2014-06-30 14:37 ` lzo1x_decompress_safe: Macro compares unsigned to 0 (NO_EFFECT) Greg Kroah-Hartman
[not found] ` <CAFkuX4uoMFC1jT4Oeqj3HzfPWG3JFiEnysODEopfL8aQod4_mQ@mail.gmail.com>
2014-06-30 16:23 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B11047.3000105@nod.at \
--to=richard@nod.at \
--cc=donb@securitymouse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@oberhumer.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.