From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>, Bandan Das <bsd@redhat.com>,
Nadav Amit <namit@cs.technion.ac.il>
Cc: gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix lapic.c debug prints
Date: Mon, 30 Jun 2014 14:12:14 +0200 [thread overview]
Message-ID: <53B1541E.4080008@redhat.com> (raw)
In-Reply-To: <53B0B773.3030107@gmail.com>
Il 30/06/2014 03:03, Nadav Amit ha scritto:
>>>
>>> sipi_vector = apic->sipi_vector;
>>> - pr_debug("vcpu %d received sipi with vector # %x\n",
>>> + apic_debug("vcpu %d received sipi with vector # %x\n",
>>
>> Why don't we just use pr_debug all throughout ?
>>
> I don't know. I just tried to make it consistent, since it really bugged
> me while I was debugging the local-apic.
> If you prefer the other way around (which does seem to be better), I can
> do the search-and-replace.
vcpu number probably could be moved inside apic_debug, at which point
apic_debug becomes preferrable.
Paolo
next prev parent reply other threads:[~2014-06-30 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 9:28 [PATCH] KVM: x86: Fix lapic.c debug prints Nadav Amit
2014-06-30 0:48 ` Bandan Das
2014-06-30 1:03 ` Nadav Amit
2014-06-30 12:12 ` Paolo Bonzini [this message]
2014-06-30 17:39 ` Bandan Das
2014-06-30 18:02 ` Paolo Bonzini
2014-06-30 18:07 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B1541E.4080008@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.