From: Paolo Bonzini <pbonzini@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] block: introduce submit I/O at batch
Date: Mon, 30 Jun 2014 14:32:07 +0200 [thread overview]
Message-ID: <53B158C7.10307@redhat.com> (raw)
In-Reply-To: <CACVXFVOCakd5i=E5Ajco1OvcEDsEokQhJnP0BZ=w+ZBxQf6mFA@mail.gmail.com>
Il 30/06/2014 14:16, Ming Lei ha scritto:
> I added the io queue into AioContext because the io queue can only
> be used in the attached context(or thread), that said the io queue has to
> be put into per context instance.
It doesn't *have* to be per-thread.
It is certainly simplest if you make it per-io_context_t, but this in
the current code means making it per-BlockDriverState and putting it in
block/linux-aio.c.
> OK, I will not consider backing_hd case in v1, also the patchset will
> not only improve dataplane, and other devices should benefit from
> it too.
>
> These patches themselves should be simple, and most of code are
> add-only, if bdrv_io_plug()/bdrv_io_unplug() isn't used, they are very close
> to noop.
>
> I just wrote a draft patch to apply the mechanism on virtio-scsi, and
> the improvement is obvious.
I certainly agree. However, we have to also consider that we're close
to releasing 2.1.
Paolo
next prev parent reply other threads:[~2014-06-30 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 9:49 [Qemu-devel] [PATCH 0/3] block: introduce submit I/O at batch Ming Lei
2014-06-30 9:49 ` [Qemu-devel] [PATCH 1/3] block: introduce IO queue APIs Ming Lei
2014-06-30 9:49 ` [Qemu-devel] [PATCH 2/3] block: linux-aio: support submit io_queue Ming Lei
2014-06-30 9:49 ` [Qemu-devel] [PATCH 3/3] dataplane: submit I/O at batch Ming Lei
2014-06-30 11:10 ` [Qemu-devel] [PATCH 0/3] block: introduce " Paolo Bonzini
2014-06-30 12:16 ` Ming Lei
2014-06-30 12:32 ` Paolo Bonzini [this message]
2014-06-30 12:49 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B158C7.10307@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.