From: Thomas Hellstrom <thellstrom@vmware.com>
To: Christopher Friedt <chrisfriedt@gmail.com>
Cc: linux-graphics-maintainer@vmware.com,
linux-kernel@vger.kernel.org,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length
Date: Mon, 30 Jun 2014 15:22:26 +0200 [thread overview]
Message-ID: <53B16492.6040006@vmware.com> (raw)
In-Reply-To: <CAF4BF-T8a_Y=uW7r_g0WKpABHFH=GhX0hNAQMsG9o=DX4JF6qg@mail.gmail.com>
On 06/30/2014 03:18 PM, Christopher Friedt wrote:
> On Mon, Jun 30, 2014 at 8:49 AM, Christopher Friedt
> <chrisfriedt@gmail.com> wrote:
>> That sounds a bit more accurate. Should kms and fbdev be setting both
>> registers then?
> I wonder if fbdev can use PITCHLOCK as well, rather than
> BYTES_PER_LINE. I will only be able to run both kms and fbdev
> functional tests about 9 hours from now, so any discussion until then
> is welcome
Please see the previous message I sent. If you just remove the line that
sets BYTES_PER_LINE,
fbdev will have called into the kms code to set PITCHLOCK correctly.
/Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Hellstrom <thellstrom@vmware.com>
To: Christopher Friedt <chrisfriedt@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel@vger.kernel.org, Dave Airlie <airlied@gmail.com>,
linux-graphics-maintainer@vmware.com
Subject: Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length
Date: Mon, 30 Jun 2014 15:22:26 +0200 [thread overview]
Message-ID: <53B16492.6040006@vmware.com> (raw)
In-Reply-To: <CAF4BF-T8a_Y=uW7r_g0WKpABHFH=GhX0hNAQMsG9o=DX4JF6qg@mail.gmail.com>
On 06/30/2014 03:18 PM, Christopher Friedt wrote:
> On Mon, Jun 30, 2014 at 8:49 AM, Christopher Friedt
> <chrisfriedt@gmail.com> wrote:
>> That sounds a bit more accurate. Should kms and fbdev be setting both
>> registers then?
> I wonder if fbdev can use PITCHLOCK as well, rather than
> BYTES_PER_LINE. I will only be able to run both kms and fbdev
> functional tests about 9 hours from now, so any discussion until then
> is welcome
Please see the previous message I sent. If you just remove the line that
sets BYTES_PER_LINE,
fbdev will have called into the kms code to set PITCHLOCK correctly.
/Thomas
next prev parent reply other threads:[~2014-06-30 13:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 0:45 [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length Christopher Friedt
2014-03-28 0:48 ` Christopher Friedt
2014-03-28 1:45 ` Dave Airlie
2014-03-28 1:45 ` Dave Airlie
2014-04-01 10:00 ` Thomas Hellstrom
2014-04-01 10:00 ` Thomas Hellstrom
2014-06-30 10:19 ` Christopher Friedt
2014-06-30 11:48 ` Thomas Hellstrom
2014-06-30 11:48 ` Thomas Hellstrom
2014-06-30 12:25 ` Christopher Friedt
2014-06-30 12:39 ` Thomas Hellstrom
2014-06-30 12:39 ` Thomas Hellstrom
2014-06-30 12:49 ` Christopher Friedt
2014-06-30 13:03 ` Thomas Hellstrom
2014-06-30 13:03 ` Thomas Hellstrom
2014-06-30 13:18 ` Christopher Friedt
2014-06-30 13:22 ` Thomas Hellstrom [this message]
2014-06-30 13:22 ` Thomas Hellstrom
2014-07-02 3:01 ` Christopher Friedt
2014-07-02 3:01 ` Christopher Friedt
2014-07-02 4:16 ` Thomas Hellstrom
2014-07-02 4:16 ` Thomas Hellstrom
2014-07-02 12:15 ` Christopher Friedt
2014-07-02 22:19 ` Christopher Friedt
2014-07-02 22:19 ` Christopher Friedt
-- strict thread matches above, loose matches on Subject: below --
2014-02-01 15:26 Christopher Friedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B16492.6040006@vmware.com \
--to=thellstrom@vmware.com \
--cc=chrisfriedt@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.