From: Stephen Warren <swarren@wwwdotorg.org>
To: Mikko Perttunen <mperttunen@nvidia.com>,
rui.zhang@intel.com, edubezval@gmail.com,
thierry.reding@gmail.com, pdeschrijver@nvidia.com,
mlongnecker@nvidia.com
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/6] ARM: tegra: Add thermal trip points for Jetson TK1
Date: Mon, 30 Jun 2014 14:45:28 -0600 [thread overview]
Message-ID: <53B1CC68.8070104@wwwdotorg.org> (raw)
In-Reply-To: <1403856699-2140-4-git-send-email-mperttunen@nvidia.com>
On 06/27/2014 02:11 AM, Mikko Perttunen wrote:
> This adds critical trip points to the Jetson TK1 device tree.
> The device will do a controlled shutdown when either the CPU, GPU
> or MEM thermal zone reaches 101 degrees Celsius.
It would be more typical to order the patches with changes to
tegra124.dtsi first, then changes to board files (that build on the core
SoC support) second.
> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> + thermal-zones {
> + cpu {
> + trips {
> + cpu-critical {
Can we name that simply "critical"? DT node names are supposed to
represent type of object more than identity of object. Even "critical"
is a bit of an identity, and "trip@0" would be better, but I imagine the
core thermal DT bindings precluded that?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] ARM: tegra: Add thermal trip points for Jetson TK1
Date: Mon, 30 Jun 2014 14:45:28 -0600 [thread overview]
Message-ID: <53B1CC68.8070104@wwwdotorg.org> (raw)
In-Reply-To: <1403856699-2140-4-git-send-email-mperttunen@nvidia.com>
On 06/27/2014 02:11 AM, Mikko Perttunen wrote:
> This adds critical trip points to the Jetson TK1 device tree.
> The device will do a controlled shutdown when either the CPU, GPU
> or MEM thermal zone reaches 101 degrees Celsius.
It would be more typical to order the patches with changes to
tegra124.dtsi first, then changes to board files (that build on the core
SoC support) second.
> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> + thermal-zones {
> + cpu {
> + trips {
> + cpu-critical {
Can we name that simply "critical"? DT node names are supposed to
represent type of object more than identity of object. Even "critical"
is a bit of an identity, and "trip at 0" would be better, but I imagine the
core thermal DT bindings precluded that?
next prev parent reply other threads:[~2014-06-30 20:45 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 8:11 [PATCH 0/6] of-thermal hardware trip points + Tegra124 SOCTHERM driver Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` [PATCH 1/6] thermal: of: Add support for hardware-tracked trip points Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-30 21:08 ` Stephen Warren
2014-06-30 21:08 ` Stephen Warren
2014-07-01 7:27 ` Mikko Perttunen
2014-07-01 7:27 ` Mikko Perttunen
2014-07-01 18:15 ` Stephen Warren
2014-07-01 18:15 ` Stephen Warren
2014-07-03 14:15 ` Mikko Perttunen
2014-07-03 14:15 ` Mikko Perttunen
2014-07-21 23:53 ` Matthew Longnecker
2014-07-30 14:16 ` Eduardo Valentin
2014-07-30 14:16 ` Eduardo Valentin
2014-08-01 11:42 ` Mikko Perttunen
2014-08-01 11:42 ` Mikko Perttunen
2014-08-01 11:42 ` Mikko Perttunen
[not found] ` <53DB7D0D.1070508-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-01 13:15 ` edubezval-Re5JQEeQqe8AvxtiuMwx3w
2014-08-01 13:15 ` edubezval
2014-08-01 13:15 ` edubezval at gmail.com
2014-06-27 8:11 ` [PATCH 2/6] of: Add bindings for nvidia,tegra124-soctherm Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
[not found] ` <1403856699-2140-3-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-30 20:40 ` Stephen Warren
2014-06-30 20:40 ` Stephen Warren
2014-06-30 20:40 ` Stephen Warren
2014-06-27 8:11 ` [PATCH 3/6] ARM: tegra: Add thermal trip points for Jetson TK1 Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-30 20:45 ` Stephen Warren [this message]
2014-06-30 20:45 ` Stephen Warren
2014-06-27 8:11 ` [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
[not found] ` <1403856699-2140-5-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-30 20:48 ` Stephen Warren
2014-06-30 20:48 ` Stephen Warren
2014-06-30 20:48 ` Stephen Warren
2014-07-01 7:49 ` Mikko Perttunen
2014-07-01 7:49 ` Mikko Perttunen
2014-07-21 23:12 ` Matthew Longnecker
2014-07-21 23:13 ` Matthew Longnecker
2014-07-21 23:13 ` Matthew Longnecker
2014-07-21 23:13 ` Matthew Longnecker
[not found] ` <1403856699-2140-1-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-27 8:11 ` [PATCH 5/6] clk: tegra: Add soctherm and tsensor clocks to Tegra124 init table Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 12:18 ` Peter De Schrijver
2014-06-27 12:18 ` Peter De Schrijver
2014-06-27 8:11 ` [PATCH 6/6] thermal: Add Tegra SOCTHERM thermal management driver Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-30 21:23 ` Stephen Warren
2014-06-30 21:23 ` Stephen Warren
2014-07-01 8:06 ` Mikko Perttunen
2014-07-01 8:06 ` Mikko Perttunen
[not found] ` <53B26BF2.7090009-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-01 18:26 ` Stephen Warren
2014-07-01 18:26 ` Stephen Warren
2014-07-01 18:26 ` Stephen Warren
2014-07-03 13:51 ` Mikko Perttunen
2014-07-03 13:51 ` Mikko Perttunen
[not found] ` <1403856699-2140-7-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-01 23:47 ` Tuomas Tynkkynen
2014-07-01 23:47 ` Tuomas Tynkkynen
2014-07-01 23:47 ` Tuomas Tynkkynen
2014-07-04 8:43 ` Wei Ni
2014-07-04 8:43 ` Wei Ni
2014-07-04 11:52 ` Mikko Perttunen
2014-07-04 11:52 ` Mikko Perttunen
2014-07-21 7:42 ` [PATCH 0/6] of-thermal hardware trip points + Tegra124 SOCTHERM driver Zhang Rui
2014-07-21 7:42 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B1CC68.8070104@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mlongnecker@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=pdeschrijver@nvidia.com \
--cc=rui.zhang@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.