From: Jens Axboe <axboe@kernel.dk>
To: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>,
pjk1939@linux.vnet.ibm.com
Cc: josh.h.morris@us.ibm.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] rsxx: fix discard with length smaller than hw blksize
Date: Mon, 30 Jun 2014 15:06:14 -0600 [thread overview]
Message-ID: <53B1D146.1060606@kernel.dk> (raw)
In-Reply-To: <1404149467-17856-1-git-send-email-cascardo@linux.vnet.ibm.com>
On 2014-06-30 11:31, Thadeu Lima de Souza Cascardo wrote:
> When the discard length is not a multiple of RSXX_HW_BLK_SIZE, the
> discard code will get into an infinite loop, even discarding data it is
> not supposed to. This will also hang the system.
>
> This can be reproduced by doing an ioctl BLKDISCARD to /dev/rsxx0 with
> range from 0 to 1024.
That is a bug that should be fixed in the discard code, not worked
around in the driver.
--
Jens Axboe
prev parent reply other threads:[~2014-06-30 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 17:31 [PATCH] rsxx: fix discard with length smaller than hw blksize Thadeu Lima de Souza Cascardo
2014-06-30 21:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B1D146.1060606@kernel.dk \
--to=axboe@kernel.dk \
--cc=cascardo@linux.vnet.ibm.com \
--cc=josh.h.morris@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjk1939@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.