From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [libvirt] [PATCH] libxl: don't break the build on Xen>=4.5 because of libxl_vcpu_setaffinity() Date: Mon, 30 Jun 2014 15:23:51 -0600 Message-ID: <53B1D567.2070908@redhat.com> References: <20140630171856.1453.59964.stgit@Solace> <53B1D266.5070904@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6888478191965070855==" Return-path: In-Reply-To: <53B1D266.5070904@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com To: Jim Fehlig , Dario Faggioli Cc: libvir-list , xen-devel@lists.xensource.com, Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6888478191965070855== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Xq6eTfJncjLd4cVvUDJB0mxWtD2rd1uTb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Xq6eTfJncjLd4cVvUDJB0mxWtD2rd1uTb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/30/2014 03:11 PM, Jim Fehlig wrote: > Dario Faggioli wrote: >> libxl interface for vcpu pinning is changing in Xen 4.5. Basically, >> libxl_set_vcpuaffinity() now wants one more parameter. That is >> representative of 'VCPU soft affinity', which libvirt does not use. >> >> To mark such change, the macro LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY is >> defined. Use it as a gate and, if present, re-#define the calls from >> the old to the new interface, to avoid breaking the build. >> =20 >=20 > Thanks, looks good. I was about to push, but wanted to check with othe= r > libvirt devs first since we are in 1.2.6 freeze. Would it be fine to > push this? It fixes a libxl driver build failure against xen-unstable.= Yes, fixing a build failure is an acceptable fix during hard freeze. Go ahead and push. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Xq6eTfJncjLd4cVvUDJB0mxWtD2rd1uTb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTsdVnAAoJEKeha0olJ0NqsBcIAIpZrpX/VSKBoxjRzOACvBNx VbIkQlTjAaHxDgAsG63te8MrRqx2DWKukwCI/GLUoMGQUQF7Xvrv/pRneCq7vb8u IZcsHxiESSe4B3W59jD8MskvDPCAomzXMQqnvRo0S01Qze6ZCF3W9EJmoIuM3hgg OW1CNzj35+NwiWx35A6M7eBi6d4NEUuyBNEC7AE5nt/h8T4pw4SXD6vzpTvjZd7d Of+yPjy1Ib+PGNfJbnoA8mFXZVBCirKJ+qct9RO8CBwiWN2reaknphfWdC0LjREE hnA34Yctlp1mxXMou+hPS2Au77BljscuSGlAFPxcuRKggctyuVXwuBnJ9kEMWQs= =yZ8R -----END PGP SIGNATURE----- --Xq6eTfJncjLd4cVvUDJB0mxWtD2rd1uTb-- --===============6888478191965070855== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6888478191965070855==--