From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: [libvirt] [PATCH] libxl: don't break the build on Xen>=4.5
 because of libxl_vcpu_setaffinity()
Date: Mon, 30 Jun 2014 15:32:14 -0600
Message-ID: <53B1D75E.5040009@suse.com>
References: <20140630171856.1453.59964.stgit@Solace>
	<53B1D266.5070904@suse.com> <53B1D567.2070908@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <libvir-list-bounces@redhat.com>
In-Reply-To: <53B1D567.2070908@redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/libvir-list>,
	<mailto:libvir-list-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/libvir-list>
List-Post: <mailto:libvir-list@redhat.com>
List-Help: <mailto:libvir-list-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/libvir-list>,
	<mailto:libvir-list-request@redhat.com?subject=subscribe>
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
To: Eric Blake <eblake@redhat.com>
Cc: libvir-list <libvir-list@redhat.com>, Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xensource.com, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Eric Blake wrote:
> On 06/30/2014 03:11 PM, Jim Fehlig wrote:
>   
>> Dario Faggioli wrote:
>>     
>>> libxl interface for vcpu pinning is changing in Xen 4.5. Basically,
>>> libxl_set_vcpuaffinity() now wants one more parameter. That is
>>> representative of 'VCPU soft affinity', which libvirt does not use.
>>>
>>> To mark such change, the macro LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY is
>>> defined. Use it as a gate and, if present, re-#define the calls from
>>> the old to the new interface, to avoid breaking the build.
>>>   
>>>       
>> Thanks, looks good.  I was about to push, but wanted to check with other
>> libvirt devs first since we are in 1.2.6 freeze.  Would it be fine to
>> push this?  It fixes a libxl driver build failure against xen-unstable.
>>     
>
> Yes, fixing a build failure is an acceptable fix during hard freeze.  Go
> ahead and push.
>   

Thanks Eric, pushed now.

Regards,
Jim