From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Tue, 01 Jul 2014 02:21:02 +0000 Subject: Re: Re: [PATCH v4] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64 Message-Id: <53B21B0E.8010707@hitachi.com> List-Id: References: <20140620022307.23075.55858.stgit@kbuild-fedora.novalocal> <53B0D61B.9010104@hitachi.com> <1404128176.7888.1.camel@concordia> In-Reply-To: <1404128176.7888.1.camel@concordia> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michael Ellerman Cc: Benjamin Herrenschmidt , Paul Mackerras , Tony Luck , Jeremy Fitzhardinge , linux-ia64@vger.kernel.org, sparse@chrisli.org, "H. Peter Anvin" , Ingo Molnar , linux-tip-commits@vger.kernel.org, akataria@vmware.com, anil.s.keshavamurthy@intel.com, "Suzuki K. Poulose" , Fenghua Yu , Arnd Bergmann , Rusty Russell , Chris Wright , yrl.pp-manager.tt@hitachi.com, Thomas Gleixner , Tony Luck , Kevin Hao , Ananth N Mavinakayanahalli , linuxppc-dev@lists.ozlabs.org, rdunlap@infradead.org, Linux Kernel Mailing List , dl9pf@gmx.de, Andrew Morton , Linus Torvalds , "David S. Miller" (2014/06/30 20:36), Michael Ellerman wrote: > On Mon, 2014-06-30 at 12:14 +0900, Masami Hiramatsu wrote: >> Ping? :) > > Yeah sorry. I started looking at this and got dragged into another mess. > > You seem to have duplicated the functionality of arch_deref_entry_point(), > which was also added for kprobes, and for the same reason - ie. because some > arches have strange function pointers. Is there some reason you can't use it? Ah, right! Hmm, it seems some more work to update it. but basically, we can do. BTW, is there any other users who need to access the actual function entry (for kallsyms case)? If so, I guess it'd better to merge this version and replace kprobe's local arch_deref_entry_point() with generic function_entry() macro. Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail9.hitachi.co.jp (mail9.hitachi.co.jp [133.145.228.44]) by lists.ozlabs.org (Postfix) with ESMTP id 178F41A0006 for ; Tue, 1 Jul 2014 12:21:11 +1000 (EST) Message-ID: <53B21B0E.8010707@hitachi.com> Date: Tue, 01 Jul 2014 11:21:02 +0900 From: Masami Hiramatsu MIME-Version: 1.0 To: Michael Ellerman Subject: Re: Re: [PATCH v4] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64 References: <20140620022307.23075.55858.stgit@kbuild-fedora.novalocal> <53B0D61B.9010104@hitachi.com> <1404128176.7888.1.camel@concordia> In-Reply-To: <1404128176.7888.1.camel@concordia> Content-Type: text/plain; charset=UTF-8 Cc: Jeremy Fitzhardinge , linux-ia64@vger.kernel.org, sparse@chrisli.org, Linux Kernel Mailing List , Paul Mackerras , "H. Peter Anvin" , akataria@vmware.com, linux-tip-commits@vger.kernel.org, anil.s.keshavamurthy@intel.com, Ingo Molnar , "Suzuki K. Poulose" , Fenghua Yu , Arnd Bergmann , Rusty Russell , Chris Wright , yrl.pp-manager.tt@hitachi.com, Thomas Gleixner , Tony Luck , Kevin Hao , Linus Torvalds , rdunlap@infradead.org, Tony Luck , dl9pf@gmx.de, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , (2014/06/30 20:36), Michael Ellerman wrote: > On Mon, 2014-06-30 at 12:14 +0900, Masami Hiramatsu wrote: >> Ping? :) > > Yeah sorry. I started looking at this and got dragged into another mess. > > You seem to have duplicated the functionality of arch_deref_entry_point(), > which was also added for kprobes, and for the same reason - ie. because some > arches have strange function pointers. Is there some reason you can't use it? Ah, right! Hmm, it seems some more work to update it. but basically, we can do. BTW, is there any other users who need to access the actual function entry (for kallsyms case)? If so, I guess it'd better to merge this version and replace kprobe's local arch_deref_entry_point() with generic function_entry() macro. Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752982AbaGACVO (ORCPT ); Mon, 30 Jun 2014 22:21:14 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:55763 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbaGACVM (ORCPT ); Mon, 30 Jun 2014 22:21:12 -0400 Message-ID: <53B21B0E.8010707@hitachi.com> Date: Tue, 01 Jul 2014 11:21:02 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Michael Ellerman Cc: Benjamin Herrenschmidt , Paul Mackerras , Tony Luck , Jeremy Fitzhardinge , linux-ia64@vger.kernel.org, sparse@chrisli.org, "H. Peter Anvin" , Ingo Molnar , linux-tip-commits@vger.kernel.org, akataria@vmware.com, anil.s.keshavamurthy@intel.com, "Suzuki K. Poulose" , Fenghua Yu , Arnd Bergmann , Rusty Russell , Chris Wright , yrl.pp-manager.tt@hitachi.com, Thomas Gleixner , Tony Luck , Kevin Hao , Ananth N Mavinakayanahalli , linuxppc-dev@lists.ozlabs.org, rdunlap@infradead.org, Linux Kernel Mailing List , dl9pf@gmx.de, Andrew Morton , Linus Torvalds , "David S. Miller" Subject: Re: Re: [PATCH v4] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64 References: <20140620022307.23075.55858.stgit@kbuild-fedora.novalocal> <53B0D61B.9010104@hitachi.com> <1404128176.7888.1.camel@concordia> In-Reply-To: <1404128176.7888.1.camel@concordia> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2014/06/30 20:36), Michael Ellerman wrote: > On Mon, 2014-06-30 at 12:14 +0900, Masami Hiramatsu wrote: >> Ping? :) > > Yeah sorry. I started looking at this and got dragged into another mess. > > You seem to have duplicated the functionality of arch_deref_entry_point(), > which was also added for kprobes, and for the same reason - ie. because some > arches have strange function pointers. Is there some reason you can't use it? Ah, right! Hmm, it seems some more work to update it. but basically, we can do. BTW, is there any other users who need to access the actual function entry (for kallsyms case)? If so, I guess it'd better to merge this version and replace kprobe's local arch_deref_entry_point() with generic function_entry() macro. Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com