All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: David Turner <dturner@twopensource.com>, git@vger.kernel.org
Cc: David Turner <dturner@twitter.com>
Subject: Re: [PATCH 1/3] cache-tree: Create/update cache-tree on checkout
Date: Tue, 01 Jul 2014 06:16:05 +0200	[thread overview]
Message-ID: <53B23605.40705@web.de> (raw)
In-Reply-To: <1404173597-24713-1-git-send-email-dturner@twitter.com>


diff --git a/t/t0090-cache-tree.sh b/t/t0090-cache-tree.sh
index 6c33e28..7c60675 100755
--- a/t/t0090-cache-tree.sh
+++ b/t/t0090-cache-tree.sh
@@ -85,9 +85,22 @@ test_expect_success 'reset --hard without index gives cache-tree' '
  	test_shallow_cache_tree
  '
  
-test_expect_failure 'checkout gives cache-tree' '
+test_expect_success 'checkout gives cache-tree' '
+	git tag current
  	git checkout HEAD^ &&
  	test_shallow_cache_tree

The && chainis broken here.
Does the test now pass, because "git tag" is added ?
In this case: does it may make sense the keep the old one as it is
an  add a new test case  like this ?

+test_expect_success 'tag and checkout gives cache-tree' '

[]

  parent reply	other threads:[~2014-07-01  4:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01  0:13 [PATCH 1/3] cache-tree: Create/update cache-tree on checkout David Turner
2014-07-01  0:13 ` [PATCH 2/3] test-dump-cache-tree: Improve output format and exit code David Turner
2014-07-01  4:43   ` Eric Sunshine
2014-07-01  0:13 ` [PATCH 3/3] cache-tree: Write index with updated cache-tree after commit David Turner
2014-07-01  4:26   ` Torsten Bögershausen
2014-07-01  5:49     ` Johannes Sixt
2014-07-01  4:16 ` Torsten Bögershausen [this message]
2014-07-01 19:15   ` [PATCH 1/3] cache-tree: Create/update cache-tree on checkout David Turner
2014-07-01 21:03     ` Junio C Hamano
2014-07-01 22:09       ` David Turner
2014-07-01 20:15 ` Junio C Hamano
2014-07-06  4:04   ` David Turner
2014-07-07 16:58     ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2014-07-01 19:14 David Turner
2014-07-01 21:08 ` Junio C Hamano
2014-06-28  0:20 David Turner
2014-06-29  3:33 ` Duy Nguyen
2014-06-30 18:13   ` Junio C Hamano
2014-06-30  6:31 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B23605.40705@web.de \
    --to=tboegi@web.de \
    --cc=dturner@twitter.com \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.