From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH v2] ARM: virt: fix wrong HSCTLR.EE bit setting
Date: Tue, 01 Jul 2014 10:23:57 +0100
Message-ID: <53B27E2D.3000405@arm.com>
References: <1404184138-12012-1-git-send-email-john.liuli@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"victor.kamensky@linaro.org" <victor.kamensky@linaro.org>,
	"hanweidong@huawei.com" <hanweidong@huawei.com>
To: "john.liuli" <john.liuli@huawei.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fw-tnat.austin.arm.com ([217.140.110.23]:21531 "EHLO
	collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753510AbaGAJX7 (ORCPT
	<rfc822;kvm@vger.kernel.org>); Tue, 1 Jul 2014 05:23:59 -0400
In-Reply-To: <1404184138-12012-1-git-send-email-john.liuli@huawei.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Li,

On 01/07/14 04:08, john.liuli wrote:
> From: Li Liu <john.liuli@huawei.com>
> 
> HSCTLR.EE is defined as bit[25] referring to arm manual
> DDI0606C.b(p1590).
> 
> changes v1 -> v2:
> 1)Use the canonical syntax for orr (orr r7, r7, #(1 << 25))
> 2)Use the ARM_BE8 macro instead of the open-coded CONFIG_CPU_BIG_ENDIAN

Two things:

- This log should not be part of the commit message, but placed after
the "---" below (do a git format-patch, edit the file produced).

- Post it also to linux-arm-kernel@lists.infradead.org, as this touches
the core ARM code and should be reviewed there.

> Signed-off-by: Li Liu <john.liuli@huawei.com>
> ---
>  arch/arm/kernel/hyp-stub.S |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm/kernel/hyp-stub.S b/arch/arm/kernel/hyp-stub.S
> index 797b1a6..7e666cf 100644
> --- a/arch/arm/kernel/hyp-stub.S
> +++ b/arch/arm/kernel/hyp-stub.S
> @@ -134,9 +134,7 @@ ENTRY(__hyp_stub_install_secondary)
>  	mcr	p15, 4, r7, c1, c1, 3	@ HSTR
>  
>  THUMB(	orr	r7, #(1 << 30)	)	@ HSCTLR.TE
> -#ifdef CONFIG_CPU_BIG_ENDIAN
> -	orr	r7, #(1 << 9)		@ HSCTLR.EE
> -#endif
> +ARM_BE8(orr	r7, r7, #(1 << 25))     @ HSCTLR.EE
>  	mcr	p15, 4, r7, c1, c0, 0	@ HSCTLR
>  
>  	mrc	p15, 4, r7, c1, c1, 1	@ HDCR
> 

Other than that, it looks good to me. When you repost it, you can add:

Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...