From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v7a 09/14] xen/arm: move and rename is_vcpu_running function to sched.h Date: Tue, 1 Jul 2014 10:32:36 +0100 Message-ID: <53B28034.4060404@eu.citrix.com> References: <1404196882-23473-1-git-send-email-vijay.kilari@gmail.com> <1404196882-23473-10-git-send-email-vijay.kilari@gmail.com> <53B285A8020000780001EDA8@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53B285A8020000780001EDA8@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , vijay.kilari@gmail.com Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K , julien.grall@linaro.org, tim@xen.org, george.dunlap@citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 07/01/2014 08:55 AM, Jan Beulich wrote: >>>> On 01.07.14 at 08:41, wrote: >> @@ -829,6 +829,20 @@ void watchdog_domain_destroy(struct domain *d); >> #define need_iommu(d) (0) >> #endif >> >> +static inline bool_t is_vcpu_online(const struct domain *d, unsigned int vcpuid) > > I'm sorry for paying attention to this only now, but a function named > this way would ordinarily have a single const struct vcpu * parameter. > If the decoding of the (domain, vcpuid) tuple is to remain in the > function I guess it ought to be renamed to e.g. is_domain_vcpu_online() +1 > (I'd further suggest to drop the is_ prefix, but I realize others may be > of different opinion). I'd probably be of the "keep the is_" opinion. :-) -George