From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 7/8] xen: arm: use superpages in p2m when
 pages are suitably aligned
Date: Tue, 01 Jul 2014 14:19:16 +0100
Message-ID: <53B2B554.7090709@linaro.org>
References: <1404202883.1829.125.camel@dagon.hellion.org.uk>
	<1404203222-30111-7-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1404203222-30111-7-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 07/01/2014 09:27 AM, Ian Campbell wrote:
> +static int p2m_create_table(struct domain *d, lpae_t *entry,
> +                            int level_shift, bool_t flush_cache)
>  {
>      struct p2m_domain *p2m = &d->arch.p2m;
>      struct page_info *page;
> -    void *p;
> +    lpae_t *p;
>      lpae_t pte;
> +    int splitting = entry->p2m.valid;

NIT: You've introduced p2m_valid earlier. I think you can use it here.

>  
> -    BUG_ON(entry->p2m.valid);
> +    BUG_ON(entry->p2m.table);

I though I've asked it before. Should not you check the valid bit by
using p2m_table?

Regards,

-- 
Julien Grall