From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1zNN-0006sT-1y for qemu-devel@nongnu.org; Tue, 01 Jul 2014 10:50:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1zMl-0001pT-4N for qemu-devel@nongnu.org; Tue, 01 Jul 2014 10:49:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1zMk-0001pA-S9 for qemu-devel@nongnu.org; Tue, 01 Jul 2014 10:49:03 -0400 Message-ID: <53B2CA58.1080906@redhat.com> Date: Tue, 01 Jul 2014 08:48:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <008601cf951f$f0f38650$d2da92f0$@Dovgaluk@ispras.ru> In-Reply-To: <008601cf951f$f0f38650$d2da92f0$@Dovgaluk@ispras.ru> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fwbRUe490OrRBCvmPbbw4XIxXXDIh5T1d" Subject: Re: [Qemu-devel] [RFC PATCH 18/22] Network packets record/replay List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , 'QEMU Developers' This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fwbRUe490OrRBCvmPbbw4XIxXXDIh5T1d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/01/2014 05:31 AM, Pavel Dovgaluk wrote: > These patches implement passing network packets to replay module in > record mode. New virtual network adapter is impelemented to replay the s/impelemented/implemented/ > packets when they are read from the log file. >=20 > Signed-off-by: Pavel Dovgalyuk > --- Please thread your messages in-reply-to the cover letter. >=20 > diff --git a/net/clients.h b/net/clients.h > index 2e8feda..d245a9f 100644 > --- a/net/clients.h > +++ b/net/clients.h > @@ -49,6 +49,10 @@ int net_init_bridge(const NetClientOptions *opts, co= nst char *name, > =20 > int net_init_l2tpv3(const NetClientOptions *opts, const char *name, > NetClientState *peer); > + =20 > +int net_init_replay(const NetClientOptions *opts, const char *name, > + NetClientState *peer); Indentation is off. > --- /dev/null > +++ b/net/net-replay.c > @@ -0,0 +1,56 @@ > +#include "net/net.h" Missing a copyright statement and declaration of license. (We prefer GPLv2+ for new files, unless you have a strong reason otherwise, but whatever you pick must be compatible with GPLv2-only) > +++ b/qapi-schema.json > @@ -2145,6 +2145,15 @@ > '*file': 'str' } } > =20 > ## > +# @NetdevReplayOptions > +# > +# Dump network traffic to the log in replay mode. > +# > +## Missing a 'Since: 2.2' designation. Is there any ability to control which file is used as the logging destination? > +{ 'type': 'NetdevReplayOptions', > + 'data': { } } > + --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fwbRUe490OrRBCvmPbbw4XIxXXDIh5T1d Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTsspYAAoJEKeha0olJ0NqMWEH/3Rova9NmyidQEvhq0UXBTRF 97rNverHMvTQmQzzyriRmOjXZu06hzPhkJan9wo2MSVzeypMZKXYfm8Vvx9LDu2a r+2LDKJ1lRNWXI+yv9jwaamQgKj+0nt21906xIaG5W84ddsi6016TCKU+PUz9g7D VGsm3q/+NHg+pm0hme2vRtY62kKB4/NRivE2ZY0V0C8kwLl4yRAPezBVE2j5bymN iZhKxhr1yt8I0AtlqT7sub0vhdvN9wu/Qtd8rrXF2KwPyYuKNBxRAVhXGfIncVGq cAmlY+gKREZ7kAEWNgA+Pxo10UBKNU+GUi8oW5NwdF1OqRfFycAJUJDIOKBabYA= =aq4a -----END PGP SIGNATURE----- --fwbRUe490OrRBCvmPbbw4XIxXXDIh5T1d--