From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49262)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X21CS-0001CW-3T
	for qemu-devel@nongnu.org; Tue, 01 Jul 2014 12:46:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X21CJ-0002lM-3G
	for qemu-devel@nongnu.org; Tue, 01 Jul 2014 12:46:32 -0400
Received: from mail-qc0-x235.google.com ([2607:f8b0:400d:c01::235]:44109)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X21CI-0002lG-US
	for qemu-devel@nongnu.org; Tue, 01 Jul 2014 12:46:23 -0400
Received: by mail-qc0-f181.google.com with SMTP id x13so8572034qcv.40
	for <qemu-devel@nongnu.org>; Tue, 01 Jul 2014 09:46:22 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53B2E5D9.9040606@redhat.com>
Date: Tue, 01 Jul 2014 18:46:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1403889855-5740-1-git-send-email-armbru@redhat.com>	<1403889855-5740-3-git-send-email-armbru@redhat.com>
	<53B2C8C0.6030303@gmail.com>
In-Reply-To: <53B2C8C0.6030303@gmail.com>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent
	BLOCK_JOB_ERROR regression
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <wenchaoqemu@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com

Il 01/07/2014 16:42, Wenchao Xia ha scritto:
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index 822fe16..fd5b579 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -1544,7 +1544,7 @@
>>   { 'event': 'BLOCK_JOB_ERROR',
>>     'data': { 'device'   : 'str',
>>               'operation': 'IoOperationType',
>> -            'action'   : 'BlockdevOnError' } }
>> +            'action'   : 'BlockErrorAction' } }
>>   
>   It is my mistake to use BlockdevOnError in code incorrectly.
> The define as 'BlockdevOnError' before is on purpose, since the
> doc for 'BlockErrorAction' says: stop means a VM is stoped, but
> for block-job it is not true, so I chosed a different type, and
> 'BlockdevOnError' seems the right one(see the doc for it). We can
> fix it in C caller or add doc in .json file later.

I think consistency between BLOCK_IO_ERROR and BLOCK_JOB_ERROR is
better.  Let's fix the BlockErrorAction documentation instead.

Paolo