From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X21ty-0005tw-Bh for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:31:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X21ts-00019a-NC for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:31:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X21ts-00019W-FB for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:31:24 -0400 Message-ID: <53B2F066.7070007@redhat.com> Date: Tue, 01 Jul 2014 11:31:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <007601cf951e$3bd3d690$b37b83b0$@Dovgaluk@ispras.ru> In-Reply-To: <007601cf951e$3bd3d690$b37b83b0$@Dovgaluk@ispras.ru> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vmS67nlJ28Whh8NMEL0cX8pt9juwjG1Rg" Subject: Re: [Qemu-devel] [RFC PATCH 02/22] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , 'QEMU Developers' This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vmS67nlJ28Whh8NMEL0cX8pt9juwjG1Rg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/01/2014 05:18 AM, Pavel Dovgaluk wrote: > These patches modify virtual hardware to make them deterministic. > We also implemented saving/restoring for several devices or fixed vm st= ate > of them to save the fields that we needed for deterministically restori= ng > behavior of the devices. >=20 > Signed-off-by: Pavel Dovgalyuk > --- >=20 Please fix your git setup to include diffstats when sending mails. It is much easier to review a patch when someone has a feel for which files are touched and how many lines are involved up front, than when they have to read the entire email. Please thread your mails in-reply-to the 0/22 cover letter. For more tips: http://wiki.qemu.org/Contribute/SubmitAPatch > +++ b/include/hw/char/serial.h > @@ -80,7 +80,7 @@ extern const MemoryRegionOps serial_io_ops; > =20 > void serial_realize_core(SerialState *s, Error **errp); > void serial_exit_core(SerialState *s); > -void serial_set_frequency(SerialState *s, uint32_t frequency); > +//void serial_set_frequency(SerialState *s, uint32_t frequency); No C99 comments (use /* */, not //). If the code is dead, nuke the line instead of commenting it out. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vmS67nlJ28Whh8NMEL0cX8pt9juwjG1Rg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTsvBmAAoJEKeha0olJ0Nq4nUIAJfGaADKbHZB9wT9rfXXSDb0 lwXfEG0LA4p7MSJn324TUicYN6S1YHetwi12U7paGbh/S+ykBznSTMrGB0BP2kiY /dShXIKG7iIaXGM9oSdIuli8PawGs2wkjrTHVNJdXTQiQFRi0ZZ06O8RaiKf8z5y b7Scr0TTAsFzeHf8H6o8jqkkmR3ZxYCCQVoZhLad84wxX/MtFiy/8hjOgervaUbb f3hj8ikCMArT7qfRhZuTTegcH2WJBUVVX39hTV2DxBBsDlxDYz5EqIWTAcAsTCY+ b0ezZ8bb+WwZFNjAOkOd0E7Em/UiIQwR4P+cj/OAcsmi6ZXXxDvmDN3U0yAOVb8= =5OrT -----END PGP SIGNATURE----- --vmS67nlJ28Whh8NMEL0cX8pt9juwjG1Rg--