All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh-pfc: r8a7791: add CAN pin groups
Date: Tue, 01 Jul 2014 18:55:42 +0000	[thread overview]
Message-ID: <53B3042E.1060606@cogentembedded.com> (raw)
In-Reply-To: <201407010211.23665.sergei.shtylyov@cogentembedded.com>

Hello.

On 07/01/2014 11:11 AM, Laurent Pinchart wrote:

>> Add CAN0/1 data/clock pin groups to R8A7791 PFC driver.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> ---
>> The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git'
>> repo.

>>   drivers/pinctrl/sh-pfc/pfc-r8a7791.c |  153 +++++++++++++++++++++++++++++++
>>   1 file changed, 153 insertions(+)

>> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
>> =================================>> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
>> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
>> @@ -1726,6 +1726,119 @@ static const unsigned int audio_clkout_m
>>   	AUDIO_CLKOUT_MARK,
>>   };
>>
>> +/* - CAN --------------------------------------------------------------- */

> [snip]

>> +static const unsigned int can_clk_c_pins[] = {
>> +	RCAR_GP_PIN(4, 31),

> Shouldn't this be (4, 30) ?

    Indeed, thank you for checking!

WBR, Sergei


  parent reply	other threads:[~2014-07-01 18:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 22:11 [PATCH] sh-pfc: r8a7791: add CAN pin groups Sergei Shtylyov
2014-07-01  7:11 ` Laurent Pinchart
2014-07-01 18:55 ` Sergei Shtylyov [this message]
2014-07-08  8:43 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B3042E.1060606@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.