Re: [PATCH 1/3] si2165: Add demod driver for DVB-T only

[Antti Palosaari <crope@iki.fi>]

Moikka Matthias!

On 07/01/2014 10:01 PM, Matthias Schwarzott wrote:
> On 17.05.2014 04:14, Antti Palosaari wrote:

>> That driver could be a little bit modern in a following ways:
>> 1) dynamic debugs
>> 2) I2C client driver model
>> 3) RegMap API
>> 4) I2C mux adapter for tuner I2C bus / gate
>>
>> Maybe 30% less LOC.
>>
>> regards
>> Antti
>
> I hope to reduce LOC by using register data tables instead of long
> chains of register writes. But mixing 8 bits and larger writes makes
> this complicated.
> 1) I could also write the larger registers byte by byte -> bad performance.
> 2) store them byte by byte and let the register array write function
> collect them.
> 3) store them together with a size indicator -> wasted space when always
> reserving 32bits for the value and normally using only 8bits.
>
> I will send the next version later.

Just send your current driver out and improve it later in order to go 
ahead. There is many devices waiting that driver... :D

regards
Antti

-- 
http://palosaari.fi/