From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 Date: Wed, 02 Jul 2014 08:52:15 +0900 Message-ID: <53B349AF.4080606@samsung.com> References: <1404175210-9278-1-git-send-email-cw00.choi@samsung.com> <53B23362.7080103@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:15133 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759256AbaGAXwS (ORCPT ); Tue, 1 Jul 2014 19:52:18 -0400 In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sachin Kamat Cc: Kukjin Kim , Tomasz Figa , Ben Dooks , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kyungmin Park , Russell King , "open list:OPEN FIRMWARE AND..." , open list , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc On 07/01/2014 01:10 PM, Sachin Kamat wrote: > Hi Chanwoo, > > On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi wrote: >> Hi Sachin, >> >> On 07/01/2014 12:33 PM, Sachin Kamat wrote: >>> Hi Chanwoo, >>> >>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi wrote: >>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high >>>> temperature for Exynos3250. >>>> >>>> Signed-off-by: Chanwoo Choi >>>> Acked-by: Kyungmin Park >>>> --- >>>> This patch has a dependency on following patch [1]: >>>> [1] https://lkml.org/lkml/2014/6/30/805 >>>> >>>> arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>>> index 3660cab..1e566af 100644 >>>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>>> @@ -192,6 +192,16 @@ >>>> status = "disabled"; >>>> }; >>>> >>>> + tmu: tmu@100C0000 { >>>> + compatible = "samsung,exynos3250-tmu"; >>>> + interrupt-parent = <&gic>; >>>> + reg = <0x100C0000 0x100>; >>>> + interrupts = <0 216 0>; >>>> + clocks = <&cmu CLK_TMU_APBIF>; >>>> + clock-names = "tmu_apbif"; >>>> + status = "disabled"; >>> >>> I don't think there would be any board specific properties needed. Hence >>> leave the status as enabled (by deleting the above line). >>> >> >> I think that if specific board need TMU feature, dts file for specific board >> should include tmu dt node with 'okay' status. The specific board based on >> Exynos3250 might not need TMU feature. > > The status field in DT node is not meant for stating the build configuration but > represents the readiness of the hardware for usage on the platform. If > a particular > board does not need this feature it needs to be disabled in the build > config and only > for any special requirements disable it in board file. TMU (Thermal Management Unit) needs specific regulator for TMU power as following: The regulator for TMU is dependent on board. For exmaple: in board dts file including tmu dt &tmu { vtmu-supply = <&ldo7_reg>; status = "okay"; }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Wed, 02 Jul 2014 08:52:15 +0900 Subject: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 In-Reply-To: References: <1404175210-9278-1-git-send-email-cw00.choi@samsung.com> <53B23362.7080103@samsung.com> Message-ID: <53B349AF.4080606@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/01/2014 01:10 PM, Sachin Kamat wrote: > Hi Chanwoo, > > On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi wrote: >> Hi Sachin, >> >> On 07/01/2014 12:33 PM, Sachin Kamat wrote: >>> Hi Chanwoo, >>> >>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi wrote: >>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high >>>> temperature for Exynos3250. >>>> >>>> Signed-off-by: Chanwoo Choi >>>> Acked-by: Kyungmin Park >>>> --- >>>> This patch has a dependency on following patch [1]: >>>> [1] https://lkml.org/lkml/2014/6/30/805 >>>> >>>> arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>>> index 3660cab..1e566af 100644 >>>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>>> @@ -192,6 +192,16 @@ >>>> status = "disabled"; >>>> }; >>>> >>>> + tmu: tmu at 100C0000 { >>>> + compatible = "samsung,exynos3250-tmu"; >>>> + interrupt-parent = <&gic>; >>>> + reg = <0x100C0000 0x100>; >>>> + interrupts = <0 216 0>; >>>> + clocks = <&cmu CLK_TMU_APBIF>; >>>> + clock-names = "tmu_apbif"; >>>> + status = "disabled"; >>> >>> I don't think there would be any board specific properties needed. Hence >>> leave the status as enabled (by deleting the above line). >>> >> >> I think that if specific board need TMU feature, dts file for specific board >> should include tmu dt node with 'okay' status. The specific board based on >> Exynos3250 might not need TMU feature. > > The status field in DT node is not meant for stating the build configuration but > represents the readiness of the hardware for usage on the platform. If > a particular > board does not need this feature it needs to be disabled in the build > config and only > for any special requirements disable it in board file. TMU (Thermal Management Unit) needs specific regulator for TMU power as following: The regulator for TMU is dependent on board. For exmaple: in board dts file including tmu dt &tmu { vtmu-supply = <&ldo7_reg>; status = "okay"; };