All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Tao <huangtao@rock-chips.com>
To: Mark Brown <broonie@kernel.org>
Cc: yzq@rock-chips.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, heiko@sntech.de, tiwai@suse.de,
	linux-kernel@vger.kernel.org, zhangqing@rock-chips.com,
	lgirdwood@gmail.com, robh+dt@kernel.org,
	kever.yang@rock-chips.com, zyw@rock-chips.com,
	jianqun <xjq@rock-chips.com>,
	kfx@rock-chips.com, grant.likely@linaro.org, cf@rock-chips.com,
	hj@rock-chips.com, zhenfu.fang@rock-chips.com
Subject: Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller
Date: Wed, 02 Jul 2014 09:01:49 +0800	[thread overview]
Message-ID: <53B359FD.3080809@rock-chips.com> (raw)
In-Reply-To: <20140701170747.GA15028@sirena.org.uk>

Hi, Mark:

于 2014年07月02日 01:07, Mark Brown 写道:
>> +static inline void i2s_writel(struct rk_i2s_dev *i2s, u32 value,
>> > +			      unsigned int offset)
>> > +{
>> > +	writel_relaxed(value, i2s->regs + offset);
>> > +}
>> > +
>> > +static inline u32 i2s_readl(struct rk_i2s_dev *i2s, unsigned int offset)
>> > +{
>> > +	return readl_relaxed(i2s->regs + offset);
>> > +}
> Perhaps use regmap?  The main advantage would be the debug
> infrastructure, though you could also use _update_bits() to reduce the
> amount of time spent locked.
>
Are you sure? This is a I2S driver, we can write the register directly,
do not through I2C or SPI bus.
Write a register is only a few instructions on ARM, but write through
regmap, it may take a long path.
I think it will just consume CPU power and make the whole thing more
complex.
Could you tell me what benefits we can get if use regmap? Or something I
just missing?

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Huang Tao <huangtao@rock-chips.com>
To: Mark Brown <broonie@kernel.org>
Cc: jianqun <xjq@rock-chips.com>,
	heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz,
	tiwai@suse.de, grant.likely@linaro.org, robh+dt@kernel.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	devicetree@vger.kernel.org, zhangqing@rock-chips.com,
	hj@rock-chips.com, kever.yang@rock-chips.com, zyw@rock-chips.com,
	yzq@rock-chips.com, zhenfu.fang@rock-chips.com,
	cf@rock-chips.com, kfx@rock-chips.com
Subject: Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller
Date: Wed, 02 Jul 2014 09:01:49 +0800	[thread overview]
Message-ID: <53B359FD.3080809@rock-chips.com> (raw)
In-Reply-To: <20140701170747.GA15028@sirena.org.uk>

Hi, Mark:

于 2014年07月02日 01:07, Mark Brown 写道:
>> +static inline void i2s_writel(struct rk_i2s_dev *i2s, u32 value,
>> > +			      unsigned int offset)
>> > +{
>> > +	writel_relaxed(value, i2s->regs + offset);
>> > +}
>> > +
>> > +static inline u32 i2s_readl(struct rk_i2s_dev *i2s, unsigned int offset)
>> > +{
>> > +	return readl_relaxed(i2s->regs + offset);
>> > +}
> Perhaps use regmap?  The main advantage would be the debug
> infrastructure, though you could also use _update_bits() to reduce the
> amount of time spent locked.
>
Are you sure? This is a I2S driver, we can write the register directly,
do not through I2C or SPI bus.
Write a register is only a few instructions on ARM, but write through
regmap, it may take a long path.
I think it will just consume CPU power and make the whole thing more
complex.
Could you tell me what benefits we can get if use regmap? Or something I
just missing?


  reply	other threads:[~2014-07-02  1:01 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01  8:37 [PATCH 0/2] add rockchip i2s driver jianqun
2014-07-01  8:37 ` jianqun
     [not found] ` <1404203860-30712-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01  8:37   ` [PATCH 1/2] ASoC: dt-bindings: add rockchip i2s bindings jianqun
2014-07-01  8:37     ` jianqun
     [not found]     ` <1404203860-30712-2-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01  8:54       ` Mark Rutland
2014-07-01  8:54         ` Mark Rutland
2014-07-01 10:08         ` jianqun
2014-07-01 10:08           ` jianqun
2014-07-04  7:26     ` [PATCH v2 " jianqun
     [not found]       ` <1404458796-6818-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-04 16:55         ` Mark Rutland
2014-07-04 16:55           ` Mark Rutland
2014-07-05 11:10       ` [PATCH v3 " jianqun
     [not found]         ` <1404558638-1739-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-09  7:40           ` Mark Brown
2014-07-09  7:40             ` Mark Brown
2014-07-01  8:47 ` [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller jianqun
     [not found]   ` <1404204458-30881-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01  9:01     ` Mark Rutland
2014-07-01  9:01       ` Mark Rutland
2014-07-01  9:51     ` [alsa-devel] " Lars-Peter Clausen
2014-07-01  9:51       ` Lars-Peter Clausen
     [not found]       ` <53B2CA5E.1060401@rock-chips.com>
2014-07-01 14:57         ` Lars-Peter Clausen
2014-07-01 15:17           ` Huang Tao
2014-07-01 17:07   ` Mark Brown
2014-07-01 17:07     ` Mark Brown
2014-07-02  1:01     ` Huang Tao [this message]
2014-07-02  1:01       ` Huang Tao
     [not found]       ` <53B359FD.3080809-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-02 10:23         ` Mark Brown
2014-07-02 10:23           ` Mark Brown
2014-07-02 10:57       ` Jianqun
2014-07-02 11:16         ` Mark Brown
2014-07-04  7:29   ` [PATCH v2 " jianqun
2014-07-04  7:29     ` jianqun
2014-07-05 11:13     ` [PATCH v3 " jianqun
2014-07-05 11:13       ` jianqun
  -- strict thread matches above, loose matches on Subject: below --
2014-07-01  8:39 [PATCH " jianqun
2014-07-01  8:39 ` jianqun
     [not found] ` <1404203972-30760-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01  9:32   ` Varka Bhadram
2014-07-01  9:32     ` Varka Bhadram
     [not found]     ` <53B28029.90408-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-01 10:11       ` Heiko Stübner
2014-07-01 10:11         ` Heiko Stübner
2014-07-11  9:54 [PATCH 0/2] add rockchip i2s driver jianqun
2014-07-11  9:58 ` [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller jianqun
2014-07-11  9:58   ` jianqun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B359FD.3080809@rock-chips.com \
    --to=huangtao@rock-chips.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cf@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=heiko@sntech.de \
    --cc=hj@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=kfx@rock-chips.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.de \
    --cc=xjq@rock-chips.com \
    --cc=yzq@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    --cc=zhenfu.fang@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.