From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <53B36A85.2010104@gmail.com> Date: Wed, 02 Jul 2014 10:12:21 +0800 From: Zhou Wang MIME-Version: 1.0 To: Caizhiyong Subject: Re: [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for hisilicon hip04 Soc References: <1404115409-20200-1-git-send-email-wangzhou.bry@gmail.com> <1404115409-20200-3-git-send-email-wangzhou.bry@gmail.com> <6920327.DpBe6vKVPa@wuerfel> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: Mark Rutland , Jussi Kivilinna , "linux-doc@vger.kernel.org" , Artem Bityutskiy , "linux-mtd@lists.infradead.org" , Russell King , Pawel Moll , Alexander Shiyan , Ezequiel Garcia , Quyaxin , Grant Likely , "devicetree@vger.kernel.org" , Arnd Bergmann , Ian Campbell , Joern Engel , Rob Herring , Pekon Gupta , "Wanli \(welly\)" , "linux-arm-kernel@lists.infradead.org" , Randy Dunlap , "linux-kernel@vger.kernel.org" , "Wangzhou \(B\)" , Kumar Gala , Ivan Khoronzhuk , Brian Norris , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2014年06月30日 17:59, Caizhiyong wrote: >> -----Original Message----- >> From: Arnd Bergmann [mailto:arnd@arndb.de] >> Sent: Monday, June 30, 2014 5:01 PM >> To: linux-arm-kernel@lists.infradead.org >> Cc: Zhou Wang; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar >> Gala; Russell King; David Woodhouse; Brian Norris; Grant Likely; Ezequiel >> Garcia; Pekon Gupta; Artem Bityutskiy; Alexander Shiyan; Ivan Khoronzhuk; >> Jussi Kivilinna; Joern Engel; Randy Dunlap; devicetree@vger.kernel.org; >> linux-mtd@lists.infradead.org; linux-doc@vger.kernel.org; >> linux-kernel@vger.kernel.org; Caizhiyong; Wangzhou (B) >> Subject: Re: [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for >> hisilicon hip04 Soc >> >> >>> + struct device *dev; >>> + void __iomem *iobase; >>> + struct completion cmd_complete; >>> + unsigned int offset; >>> + unsigned int command; >>> + int chipselect; >>> + unsigned int addr_cycle; >>> + unsigned int addr_value[2]; >>> + unsigned int cache_addr_value[2]; >>> + char *buffer; >>> + dma_addr_t dma_buffer; >>> + dma_addr_t dma_oob; >>> + int version; >>> + unsigned int ecc_bits; >>> + unsigned int irq_status; /* interrupt status */ >>> + >>> + int (*send_cmd_pageprog)(struct hinfc_host *host); >>> + int (*send_cmd_status)(struct hinfc_host *host); >>> + int (*send_cmd_readstart)(struct hinfc_host *host); >>> + int (*send_cmd_erase)(struct hinfc_host *host); >>> + int (*send_cmd_readid)(struct hinfc_host *host); >>> + int (*send_cmd_reset)(struct hinfc_host *host, int chipselect); >>> +}; >> >> Why do you need function pointers here? The current version of the >> driver you posted always assigns these to the same functions, so >> it would be more efficient to just call those directly. >> > > I agree with you. > This feature was originally designed to support a variety version of NAND controllers. > But in fact, this feature is not used now. > I will move them out the host, thanks for your opinion! From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangzhou.bry@gmail.com (Zhou Wang) Date: Wed, 02 Jul 2014 10:12:21 +0800 Subject: [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for hisilicon hip04 Soc In-Reply-To: References: <1404115409-20200-1-git-send-email-wangzhou.bry@gmail.com> <1404115409-20200-3-git-send-email-wangzhou.bry@gmail.com> <6920327.DpBe6vKVPa@wuerfel> Message-ID: <53B36A85.2010104@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2014?06?30? 17:59, Caizhiyong wrote: >> -----Original Message----- >> From: Arnd Bergmann [mailto:arnd at arndb.de] >> Sent: Monday, June 30, 2014 5:01 PM >> To: linux-arm-kernel at lists.infradead.org >> Cc: Zhou Wang; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar >> Gala; Russell King; David Woodhouse; Brian Norris; Grant Likely; Ezequiel >> Garcia; Pekon Gupta; Artem Bityutskiy; Alexander Shiyan; Ivan Khoronzhuk; >> Jussi Kivilinna; Joern Engel; Randy Dunlap; devicetree at vger.kernel.org; >> linux-mtd at lists.infradead.org; linux-doc at vger.kernel.org; >> linux-kernel at vger.kernel.org; Caizhiyong; Wangzhou (B) >> Subject: Re: [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for >> hisilicon hip04 Soc >> >> >>> + struct device *dev; >>> + void __iomem *iobase; >>> + struct completion cmd_complete; >>> + unsigned int offset; >>> + unsigned int command; >>> + int chipselect; >>> + unsigned int addr_cycle; >>> + unsigned int addr_value[2]; >>> + unsigned int cache_addr_value[2]; >>> + char *buffer; >>> + dma_addr_t dma_buffer; >>> + dma_addr_t dma_oob; >>> + int version; >>> + unsigned int ecc_bits; >>> + unsigned int irq_status; /* interrupt status */ >>> + >>> + int (*send_cmd_pageprog)(struct hinfc_host *host); >>> + int (*send_cmd_status)(struct hinfc_host *host); >>> + int (*send_cmd_readstart)(struct hinfc_host *host); >>> + int (*send_cmd_erase)(struct hinfc_host *host); >>> + int (*send_cmd_readid)(struct hinfc_host *host); >>> + int (*send_cmd_reset)(struct hinfc_host *host, int chipselect); >>> +}; >> >> Why do you need function pointers here? The current version of the >> driver you posted always assigns these to the same functions, so >> it would be more efficient to just call those directly. >> > > I agree with you. > This feature was originally designed to support a variety version of NAND controllers. > But in fact, this feature is not used now. > I will move them out the host, thanks for your opinion! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhou Wang Subject: Re: [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for hisilicon hip04 Soc Date: Wed, 02 Jul 2014 10:12:21 +0800 Message-ID: <53B36A85.2010104@gmail.com> References: <1404115409-20200-1-git-send-email-wangzhou.bry@gmail.com> <1404115409-20200-3-git-send-email-wangzhou.bry@gmail.com> <6920327.DpBe6vKVPa@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Caizhiyong Cc: Mark Rutland , Jussi Kivilinna , "linux-doc@vger.kernel.org" , Artem Bityutskiy , "linux-mtd@lists.infradead.org" , Russell King , Pawel Moll , Alexander Shiyan , Ezequiel Garcia , Quyaxin , Grant Likely , "devicetree@vger.kernel.org" , Arnd Bergmann , Ian Campbell , Joern Engel , Rob Herring , Pekon Gupta , "Wanli (welly)" , "linux-arm-kernel@lists.infradead.org" , Randy Dunlap List-Id: devicetree@vger.kernel.org T24gMjAxNOW5tDA25pyIMzDml6UgMTc6NTksIENhaXpoaXlvbmcgd3JvdGU6Cj4+IC0tLS0tT3Jp Z2luYWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IEFybmQgQmVyZ21hbm4gW21haWx0bzphcm5kQGFy bmRiLmRlXQo+PiBTZW50OiBNb25kYXksIEp1bmUgMzAsIDIwMTQgNTowMSBQTQo+PiBUbzogbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCj4+IENjOiBaaG91IFdhbmc7IFJvYiBI ZXJyaW5nOyBQYXdlbCBNb2xsOyBNYXJrIFJ1dGxhbmQ7IElhbiBDYW1wYmVsbDsgS3VtYXIKPj4g R2FsYTsgUnVzc2VsbCBLaW5nOyBEYXZpZCBXb29kaG91c2U7IEJyaWFuIE5vcnJpczsgR3JhbnQg TGlrZWx5OyBFemVxdWllbAo+PiBHYXJjaWE7IFBla29uIEd1cHRhOyBBcnRlbSBCaXR5dXRza2l5 OyBBbGV4YW5kZXIgU2hpeWFuOyBJdmFuIEtob3JvbnpodWs7Cj4+IEp1c3NpIEtpdmlsaW5uYTsg Sm9lcm4gRW5nZWw7IFJhbmR5IER1bmxhcDsgZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7Cj4+ IGxpbnV4LW10ZEBsaXN0cy5pbmZyYWRlYWQub3JnOyBsaW51eC1kb2NAdmdlci5rZXJuZWwub3Jn Owo+PiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBDYWl6aGl5b25nOyBXYW5nemhvdSAo QikKPj4gU3ViamVjdDogUmU6IFtQQVRDSCAyLzNdIG10ZDogaGlzaWxpY29uOiBhZGQgYSBuZXcg bmFuZCBjb250cm9sbGVyIGRyaXZlciBmb3IKPj4gaGlzaWxpY29uIGhpcDA0IFNvYwo+Pgo+Pgo+ Pj4gKwlzdHJ1Y3QgZGV2aWNlCQkqZGV2Owo+Pj4gKwl2b2lkIF9faW9tZW0JCSppb2Jhc2U7Cj4+ PiArCXN0cnVjdCBjb21wbGV0aW9uICAgICAgIGNtZF9jb21wbGV0ZTsKPj4+ICsJdW5zaWduZWQg aW50CQlvZmZzZXQ7Cj4+PiArCXVuc2lnbmVkIGludAkJY29tbWFuZDsKPj4+ICsJaW50CQkJY2hp cHNlbGVjdDsKPj4+ICsJdW5zaWduZWQgaW50CQlhZGRyX2N5Y2xlOwo+Pj4gKwl1bnNpZ25lZCBp bnQJCWFkZHJfdmFsdWVbMl07Cj4+PiArCXVuc2lnbmVkIGludAkJY2FjaGVfYWRkcl92YWx1ZVsy XTsKPj4+ICsJY2hhcgkJCSpidWZmZXI7Cj4+PiArCWRtYV9hZGRyX3QJCWRtYV9idWZmZXI7Cj4+ PiArCWRtYV9hZGRyX3QJCWRtYV9vb2I7Cj4+PiArCWludAkJCXZlcnNpb247Cj4+PiArCXVuc2ln bmVkIGludCAgICAgICAgICAgIGVjY19iaXRzOwo+Pj4gKwl1bnNpZ25lZCBpbnQgICAgICAgICAg ICBpcnFfc3RhdHVzOyAvKiBpbnRlcnJ1cHQgc3RhdHVzICovCj4+PiArCj4+PiArCWludCAoKnNl bmRfY21kX3BhZ2Vwcm9nKShzdHJ1Y3QgaGluZmNfaG9zdCAqaG9zdCk7Cj4+PiArCWludCAoKnNl bmRfY21kX3N0YXR1cykoc3RydWN0IGhpbmZjX2hvc3QgKmhvc3QpOwo+Pj4gKwlpbnQgKCpzZW5k X2NtZF9yZWFkc3RhcnQpKHN0cnVjdCBoaW5mY19ob3N0ICpob3N0KTsKPj4+ICsJaW50ICgqc2Vu ZF9jbWRfZXJhc2UpKHN0cnVjdCBoaW5mY19ob3N0ICpob3N0KTsKPj4+ICsJaW50ICgqc2VuZF9j bWRfcmVhZGlkKShzdHJ1Y3QgaGluZmNfaG9zdCAqaG9zdCk7Cj4+PiArCWludCAoKnNlbmRfY21k X3Jlc2V0KShzdHJ1Y3QgaGluZmNfaG9zdCAqaG9zdCwgaW50IGNoaXBzZWxlY3QpOwo+Pj4gK307 Cj4+Cj4+IFdoeSBkbyB5b3UgbmVlZCBmdW5jdGlvbiBwb2ludGVycyBoZXJlPyBUaGUgY3VycmVu dCB2ZXJzaW9uIG9mIHRoZQo+PiBkcml2ZXIgeW91IHBvc3RlZCBhbHdheXMgYXNzaWducyB0aGVz ZSB0byB0aGUgc2FtZSBmdW5jdGlvbnMsIHNvCj4+IGl0IHdvdWxkIGJlIG1vcmUgZWZmaWNpZW50 IHRvIGp1c3QgY2FsbCB0aG9zZSBkaXJlY3RseS4KPj4KPgo+IEkgYWdyZWUgd2l0aCB5b3UuCj4g VGhpcyBmZWF0dXJlIHdhcyBvcmlnaW5hbGx5IGRlc2lnbmVkIHRvIHN1cHBvcnQgYSB2YXJpZXR5 IHZlcnNpb24gb2YgTkFORCBjb250cm9sbGVycy4KPiBCdXQgaW4gZmFjdCwgdGhpcyBmZWF0dXJl IGlzIG5vdCB1c2VkIG5vdy4KPgpJIHdpbGwgbW92ZSB0aGVtIG91dCB0aGUgaG9zdCwgdGhhbmtz IGZvciB5b3VyIG9waW5pb24hCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=