From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Medve Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check. Date: Wed, 2 Jul 2014 02:46:01 -0500 Message-ID: <53B3B8B9.30400@Freescale.com> References: <1403618237-26248-1-git-send-email-Varun.Sethi@freescale.com> <1403618237-26248-2-git-send-email-Varun.Sethi__13822.953499812$1403630309$gmane$org@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1403618237-26248-2-git-send-email-Varun.Sethi__13822.953499812$1403630309$gmane$org@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Varun Sethi , iommu@lists.linux-foundation.org, joro@8bytes.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alex.williamson@redhat.com List-Id: iommu@lists.linux-foundation.org T24gMDYvMjQvMjAxNCAwODo1NyBBTSwgVmFydW4gU2V0aGkgd3JvdGU6Cj4gaXNfcG93ZXJfb2Zf MiByZXF1aXJlcyBhbiB1bnNpZ25lZCBsb25nIHBhcmFtZXRlciB3aGljaCB3b3VsZAo+IGxlYWQg dG8gdHJ1bmNhdGlvbiBvZiA2NCBiaXQgdmFsdWVzIG9uIDMyIGJpdCBhcmNoaXRlY3R1cmVzLgo+ IAo+IF9fZmZzIGFsc28gZXhwZWN0cyBhbiB1bnNpZ25lZCBsb25nIHBhcmFtZXRlciB0aHVzIHdv bid0IHdvcmsKPiBmb3IgNjQgYml0IHZhbHVlcyBvbiAzMiBiaXQgYXJjaGl0ZWN0dXJlcy4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBWYXJ1biBTZXRoaSA8VmFydW4uU2V0aGlAZnJlZXNjYWxlLmNvbT4K PiAtLS0KPiAgZHJpdmVycy9pb21tdS9mc2xfcGFtdS5jICAgICAgICB8ICAgIDggKysrKy0tLS0K PiAgZHJpdmVycy9pb21tdS9mc2xfcGFtdV9kb21haW4uYyB8ICAgIDIgKy0KPiAgMiBmaWxlcyBj aGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpUZXN0ZWQtYnk6IEVtaWwg TWVkdmUgPEVtaWxpYW4uTWVkdmVARnJlZXNjYWxlLmNvbT4KCk9uIGEgUDQwODAgRFMgKGkuZS4g MzItYml0IFNvQykKCgpDaGVlcnMsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QKTGludXhwcGMtZGV2QGxpc3Rz Lm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4cHBjLWRl dg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1lp0139.outbound.protection.outlook.com [207.46.163.139]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 89C791A0015 for ; Wed, 2 Jul 2014 17:54:44 +1000 (EST) Message-ID: <53B3B8B9.30400@Freescale.com> Date: Wed, 2 Jul 2014 02:46:01 -0500 From: Emil Medve MIME-Version: 1.0 To: Varun Sethi , , , , , Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check. References: <1403618237-26248-1-git-send-email-Varun.Sethi@freescale.com> <1403618237-26248-2-git-send-email-Varun.Sethi__13822.953499812$1403630309$gmane$org@freescale.com> In-Reply-To: <1403618237-26248-2-git-send-email-Varun.Sethi__13822.953499812$1403630309$gmane$org@freescale.com> Content-Type: text/plain; charset="UTF-8" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/24/2014 08:57 AM, Varun Sethi wrote: > is_power_of_2 requires an unsigned long parameter which would > lead to truncation of 64 bit values on 32 bit architectures. > > __ffs also expects an unsigned long parameter thus won't work > for 64 bit values on 32 bit architectures. > > Signed-off-by: Varun Sethi > --- > drivers/iommu/fsl_pamu.c | 8 ++++---- > drivers/iommu/fsl_pamu_domain.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) Tested-by: Emil Medve On a P4080 DS (i.e. 32-bit SoC) Cheers,