All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Why has the timeout be removed?
Date: Wed, 02 Jul 2014 09:52:19 +0200	[thread overview]
Message-ID: <53B3BA33.7090002@redhat.com> (raw)
In-Reply-To: <4109187.o2ig1JcEG2@d46>

On 01.07.2014 17:59, Thomas Renninger wrote:
> Hi,
> 
> 
> commit 8ee18253644a812184c60e31d7ee3d3f6d8f45c0
> Author: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Date:   Tue Mar 4 13:46:14 2014 +0100
> 
>     dracut: don't let devices timeout
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=949697
> 
> 
> See the whole diff at the end.
> This one removes timeouts on the rootfs and if the rootfs
> cannot be accessed early boot will remain hung forever.
> 
> Unfortunately I cannot access the bug reference from
> the changelog and the changelog does not describe the problem.
> 
> I would like to revive the/a timeout, but need to understand
> why it got removed.
> 
> Thanks,
> 
>       Thomas
> 
> 
> =============================================
>    
> 
> diff --git a/modules.d/98systemd/rootfs-generator.sh b/modules.d/98systemd/rootfs-generator.sh
> index a11ce59..2c09895 100755
> --- a/modules.d/98systemd/rootfs-generator.sh
> +++ b/modules.d/98systemd/rootfs-generator.sh
> @@ -29,7 +29,7 @@ generator_wait_for_dev()
>          mkdir -p /run/systemd/generator/${_name}.device.d
>          {
>              echo "[Unit]"
> -            echo "JobTimeoutSec=3600"
> +            echo "JobTimeoutSec=0"
>          } > /run/systemd/generator/${_name}.device.d/timeout.conf
>      fi
>  }
> diff --git a/modules.d/99base/dracut-lib.sh b/modules.d/99base/dracut-lib.sh
> index 763b7e2..e4d7da8 100755
> --- a/modules.d/99base/dracut-lib.sh
> +++ b/modules.d/99base/dracut-lib.sh
> @@ -891,7 +891,7 @@ wait_for_dev()
>              mkdir -p ${PREFIX}/etc/systemd/system/${_name}.device.d
>              {
>                  echo "[Unit]"
> -                echo "JobTimeoutSec=3600"
> +                echo "JobTimeoutSec=0"
>              } > ${PREFIX}/etc/systemd/system/${_name}.device.d/timeout.conf
>              _needreload=1
>          fi
> 
> =============================================
> 

The main reason was that for encrypted devices it would timeout, if you don't
enter the password in time.

If you solve that, then you can reintroduce the timeout.

      reply	other threads:[~2014-07-02  7:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 15:59 Why has the timeout be removed? Thomas Renninger
2014-07-02  7:52 ` Harald Hoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B3BA33.7090002@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=trenn-l3A5Bk7waGM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.