From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2FrK-0007OR-H8 for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:25:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2FrB-0001WE-4v for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:25:42 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:35702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2FrA-0001Vy-Rb for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:25:33 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Jul 2014 09:25:31 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 0411517D805A for ; Wed, 2 Jul 2014 09:26:59 +0100 (BST) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s628PSa833226890 for ; Wed, 2 Jul 2014 08:25:28 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s628PQlj018282 for ; Wed, 2 Jul 2014 02:25:26 -0600 Message-ID: <53B3C1EE.1060107@de.ibm.com> Date: Wed, 02 Jul 2014 10:25:18 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1404228309-21122-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1404228309-21122-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virtio-blk request handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , ming.lei@canonical.com, Fam Zheng On 01/07/14 17:25, Stefan Hajnoczi wrote: > This series fixes issues recently introduced when unifying virtio-blk > dataplane's request handling with non-dataplane virtio-blk. > > The problems include broken memory allocation for dataplane requests and a > performance regression for non-dataplane. See the patches for details. > > Stefan Hajnoczi (4): > virtio-blk: avoid dataplane VirtIOBlockReq early free > dataplane: do not free VirtQueueElement in vring_push() > virtio-blk: avoid g_slice_new0() for VirtIOBlockReq and > VirtQueueElement > virtio-blk: embed VirtQueueElement in VirtIOBlockReq > > hw/block/dataplane/virtio-blk.c | 30 +++++++++++----------- > hw/block/virtio-blk.c | 50 ++++++++++++++++++------------------- > hw/virtio/dataplane/vring.c | 22 ++++++---------- > include/hw/virtio/dataplane/vring.h | 3 +-- > include/hw/virtio/virtio-blk.h | 6 ++++- > 5 files changed, 53 insertions(+), 58 deletions(-) > I need patches 1 and 2 to make dataplane work. For both patches Tested-by: Christian Borntraeger Would be good to see both patches in master soon. (no opinion about 3 and 4). Christian