From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding Date: Wed, 02 Jul 2014 12:17:54 +0200 Message-ID: <53B3DC52.7040803@collabora.co.uk> References: <1403806546-31122-1-git-send-email-javier.martinez@collabora.co.uk> <1403806546-31122-5-git-send-email-javier.martinez@collabora.co.uk> <20140701172959.32686.9863@quantum> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from bhuna.collabora.co.uk ([93.93.135.160]:36795 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbaGBKSE (ORCPT ); Wed, 2 Jul 2014 06:18:04 -0400 In-Reply-To: <20140701172959.32686.9863@quantum> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Mike Turquette , Lee Jones Cc: Samuel Ortiz , Mark Brown , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Sjoerd Simons , Daniel Stone , Tomeu Vizoso , Krzysztof Kozlowski , Yadwinder Singh Brar , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Hello Mike, On 07/01/2014 07:29 PM, Mike Turquette wrote: > Quoting Javier Martinez Canillas (2014-06-26 11:15:36) >> Like most clock drivers, the Maxim 77686 PMIC clock binding >> follows the convention that the "#clock-cells" property is >> used to specify the number of cells in a clock provider. >> >> But the binding document is not clear enough that it shall >> be set to 1 since the PMIC support multiple clocks outputs. >> >> Also, explain that the clocks identifiers are defined in a >> header file that can be included by Device Tree source with >> client nodes to avoid using magic numbers. >> >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Krzysztof Kozlowski >> Reviewed-by: Doug Anderson > > Looks good to me. > > Regards, > Mike > Thanks a lot, an Acked-by or Reviewed-by tags for this patch and 03/14 will be great as well so I can carry those on the next version of the series. Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) Date: Wed, 02 Jul 2014 12:17:54 +0200 Subject: [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding In-Reply-To: <20140701172959.32686.9863@quantum> References: <1403806546-31122-1-git-send-email-javier.martinez@collabora.co.uk> <1403806546-31122-5-git-send-email-javier.martinez@collabora.co.uk> <20140701172959.32686.9863@quantum> Message-ID: <53B3DC52.7040803@collabora.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Mike, On 07/01/2014 07:29 PM, Mike Turquette wrote: > Quoting Javier Martinez Canillas (2014-06-26 11:15:36) >> Like most clock drivers, the Maxim 77686 PMIC clock binding >> follows the convention that the "#clock-cells" property is >> used to specify the number of cells in a clock provider. >> >> But the binding document is not clear enough that it shall >> be set to 1 since the PMIC support multiple clocks outputs. >> >> Also, explain that the clocks identifiers are defined in a >> header file that can be included by Device Tree source with >> client nodes to avoid using magic numbers. >> >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Krzysztof Kozlowski >> Reviewed-by: Doug Anderson > > Looks good to me. > > Regards, > Mike > Thanks a lot, an Acked-by or Reviewed-by tags for this patch and 03/14 will be great as well so I can carry those on the next version of the series. Best regards, Javier