From: Paolo Bonzini <pbonzini@redhat.com>
To: ChenLiang <chenliang88@huawei.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] ide: fix double free
Date: Wed, 02 Jul 2014 13:24:00 +0200 [thread overview]
Message-ID: <53B3EBD0.8080701@redhat.com> (raw)
In-Reply-To: <53B3E92E.1040909@huawei.com>
Il 02/07/2014 13:12, ChenLiang ha scritto:
> This patch avoid freeing dbs by dma_complete when dma_aio_cancel is running.
> Because dma_complete also will be called by dma_bdrv_cb. So double free
> will never happen.
Yes, you already said that. But I'm not sure _why_ the patch avoids
freeing dbs, especially since the patch adds a free in dma_aio_cancel
itself. My patch shouldn't have any effect. Where is my analysis of it
wrong?
Paolo
next prev parent reply other threads:[~2014-07-02 11:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 8:50 [Qemu-devel] [PATCH] ide: fix double free arei.gonglei
2014-07-02 9:04 ` Paolo Bonzini
2014-07-02 9:24 ` ChenLiang
2014-07-02 9:25 ` Paolo Bonzini
2014-07-02 9:46 ` Gonglei (Arei)
2014-07-02 10:16 ` Paolo Bonzini
2014-07-02 11:12 ` ChenLiang
2014-07-02 11:24 ` Paolo Bonzini [this message]
2014-07-02 11:33 ` ChenLiang
2014-07-02 11:40 ` Paolo Bonzini
2014-07-02 11:57 ` ChenLiang
2014-07-02 12:19 ` Paolo Bonzini
2014-07-02 12:46 ` 陈梁
2014-07-02 12:54 ` 陈梁
2014-07-02 13:09 ` Paolo Bonzini
2014-07-03 2:23 ` ChenLiang
2014-07-03 10:41 ` Paolo Bonzini
2014-07-07 8:12 ` ChenLiang
2014-07-07 12:38 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3EBD0.8080701@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=chenliang88@huawei.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.