All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	vinod.koul@intel.com, dan.j.williams@intel.com, tiwai@suse.de,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	joelf@ti.com, nsekhar@ti.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH 3/4] ALSA: pcm_dmaengine: Use the available wrapper to get physical width
Date: Wed, 02 Jul 2014 13:46:46 +0200	[thread overview]
Message-ID: <53B3F126.5060709@metafoo.de> (raw)
In-Reply-To: <1404300570-14082-4-git-send-email-peter.ujfalusi@ti.com>

On 07/02/2014 01:29 PM, Peter Ujfalusi wrote:
> params_physical_width() is available via pcm_params.h
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

> ---
>   sound/core/pcm_dmaengine.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c
> index 76cbb9ec953a..d5611ec80381 100644
> --- a/sound/core/pcm_dmaengine.c
> +++ b/sound/core/pcm_dmaengine.c
> @@ -65,7 +65,7 @@ int snd_hwparams_to_dma_slave_config(const struct snd_pcm_substream *substream,
>   	enum dma_slave_buswidth buswidth;
>   	int bits;
>
> -	bits = snd_pcm_format_physical_width(params_format(params));
> +	bits = params_physical_width(params);
>   	if (bits < 8 || bits > 64)
>   		return -EINVAL;
>   	else if (bits == 8)
>

  reply	other threads:[~2014-07-02 11:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 11:29 [PATCH 0/4] ALSA/dmaengine: Fix 3 bytes physical sample support Peter Ujfalusi
2014-07-02 11:29 ` Peter Ujfalusi
2014-07-02 11:29 ` [PATCH 1/4] dma: Support for 3 bytes word size Peter Ujfalusi
2014-07-02 11:29   ` Peter Ujfalusi
2014-07-02 11:29 ` [PATCH 2/4] dma: edma: Declare DMA_SLAVE_BUSWIDTH_3_BYTES as supported buswidth Peter Ujfalusi
2014-07-02 11:29   ` Peter Ujfalusi
2014-07-02 11:29 ` [PATCH 3/4] ALSA: pcm_dmaengine: Use the available wrapper to get physical width Peter Ujfalusi
2014-07-02 11:29   ` Peter Ujfalusi
2014-07-02 11:46   ` Lars-Peter Clausen [this message]
2014-07-02 11:29 ` [PATCH 4/4] ALSA: pcm_dmaengine: Correct support for 3 physical bytes samples Peter Ujfalusi
2014-07-02 11:29   ` Peter Ujfalusi
2014-07-02 12:44   ` Peter Ujfalusi
2014-07-02 12:44     ` Peter Ujfalusi
2014-07-02 12:48     ` Lars-Peter Clausen
2014-07-02 12:56       ` Peter Ujfalusi
2014-07-02 12:56         ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B3F126.5060709@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=joelf@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.