From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH] do not use --symlink for autoreconf Date: Wed, 02 Jul 2014 14:57:28 +0200 Message-ID: <53B401B8.6010102@pengutronix.de> References: <1404303178-24608-1-git-send-email-nautsch2@gmail.com> <53B3F88E.2080202@pengutronix.de> <53B3FC62.1030209@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nsmpmfffuhTFX3MNJ7EXonsrgW77PwFdc" Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:47310 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbaGBM5i (ORCPT ); Wed, 2 Jul 2014 08:57:38 -0400 In-Reply-To: <53B3FC62.1030209@gmail.com> Sender: linux-can-owner@vger.kernel.org List-ID: To: Andre Naujoks , linux-can@vger.kernel.org Cc: socketcan@hartkopp.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nsmpmfffuhTFX3MNJ7EXonsrgW77PwFdc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/02/2014 02:34 PM, Andre Naujoks wrote: > On 02.07.2014 14:18, Marc Kleine-Budde wrote: >> On 07/02/2014 02:12 PM, Andre Naujoks wrote: >>> When packaging the can-utils, I understand, that the generation >>> step for autoconf should be done beforehand. However using the >>> --symlink option in the autoreconf step installs links instead of >>> the actual files, which leads to a build failure when trying to >>> build on another host with different autotools installed. >>> >>> Signed-off-by: Andre Naujoks >> >> How do you package the can-utils? The usual steps are: >> >> ./autogen.sh ./configure make dist >=20 > with git archive. Something like >=20 > git archive --prefix=3Dcan-utils-`git describe --always --dirty`/ -o > can-utils-`git describe --always --dirty`.tar.gz HEAD AFAIK: git will not archive any files that are not in git, thus no files generated by autoconf.sh. > I was not aware of the dist target. Why do I have to configure before > creating the dist? Isn't the configure step just for adaptations for > the build-host and target? Usually you're right, but wihtout the autogen.sh && ./configure run, there are no makefiles that contian the code for make dist. Note: the can-utils package hold a handcraftet Makefile for the people who don't like autotools. And autotools will generate GNUmakefile, which has a higher priority for gnu make. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --nsmpmfffuhTFX3MNJ7EXonsrgW77PwFdc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlO0AbgACgkQjTAFq1RaXHOFTgCfRtsvxoJwRcis9P70/D9d0iXd XeAAniTgphdQ89W7s7axCML+w5iaMPdV =Pp/o -----END PGP SIGNATURE----- --nsmpmfffuhTFX3MNJ7EXonsrgW77PwFdc--