From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Small fixes after GICv2 changes by commit ee65c87 Date: Wed, 02 Jul 2014 14:14:43 +0100 Message-ID: <53B405C3.2030408@linaro.org> References: <1404304489-24396-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X2KN7-0007Rb-IG for xen-devel@lists.xenproject.org; Wed, 02 Jul 2014 13:14:49 +0000 Received: by mail-wg0-f44.google.com with SMTP id x13so11102565wgg.15 for ; Wed, 02 Jul 2014 06:14:48 -0700 (PDT) In-Reply-To: <1404304489-24396-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com, tim@xen.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 07/02/2014 01:34 PM, Julien Grall wrote: > The commit ee65c87 moves the GICv2 code in a separate file. Even though this > patch is only deals with code movement, a comment was modify for no reason. > > Also rename gic_v2_init into gicv2_setup which is what the function does > and less confusing with the other function called gicv2_init. > > Signed-off-by: Julien Grall > --- > xen/arch/arm/gic-v2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c > index 695c232..74c72d6 100644 > --- a/xen/arch/arm/gic-v2.c > +++ b/xen/arch/arm/gic-v2.c > @@ -372,12 +372,12 @@ static void gicv2_clear_lr(int lr) > writel_relaxed(0, GICH + GICH_LR + lr * 4); > } > > -static int gicv_v2_init(struct domain *d) > +static int gicv2_setup(struct domain *d) Hmmmm... I forgot to modify the caller. :/ I will send a v2 right now. -- Julien Grall